Repository navigation
fix(operator): derive default v1beta2 AISimulate image - #1
Merged
devivasudevan merged 1 commit intoOct 22, 2026
Conversation
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
|
👋 Hi sttts! Thank you for contributing to devivasudevan/dynamo. Just a reminder: The 🚀 |
devivasudevan
merged commit Oct 22, 2026
f2c2a7e
into
devivasudevan:dgdr-admission-v2
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1beta2 model-only DGDRs currently fail under the default Helm values because
dgdrAISimulateDefaultImageis empty, admission persists nospec.aisimulate.image, and validation rejects the request.This change reuses the existing DGDR planner-image resolver for v1beta2. An empty operator option now derives a version-matched planner image from
--operator-version; an explicitly configureddgdrAISimulateDefaultImagestill wins.With the release chart's
appVersion: 1.6.0, this request:is admitted with:
The chart already passes
.Chart.AppVersionas--operator-version. Pre-release, nightly, or custom images can continue to setcontrollerManager.manager.dgdrAISimulateDefaultImageexplicitly.The production admission envtest no longer injects a fake AISimulate image. Its model-only case now proves that the operator version supplies and persists the default.
Stacked on ai-dynamo#16661.
Validation
go test ./internal/webhook/defaultingKUBEBUILDER_ASSETS=<absolute envtest path> go test ./internal/webhook/validation -run 'TestDynamoGraphDeploymentRequestValidator_Validate/v1beta2_model-only_request_gets_schema_and_admission_defaults'go test ./cmd ./api/v1beta2make generate-api-docs