Repository navigation
feat(ai): expose configurable HNSW search breadth - #438
Merged
Merged
Conversation
Signed-off-by: Jim Ezesinachi <ezesinachijim@gmail.com>
Test Results508 tests 508 ✅ 21m 56s ⏱️ Results for commit e886bc1. ♻️ This comment has been updated with latest results. |
deven96
approved these changes
Oct 9, 2026
Signed-off-by: Jim Ezesinachi <ezesinachijim@gmail.com>
Benchmark Results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI searches currently omit DB's configurable HNSW search breadth, so callers cannot tune
ef_searchthrough the AI API. Add optionalef_searchto AIGetSimNand forward it unchanged to DB. Reject zero before model inference; omission preserves the server defaultmax(closest_n, 50), and DB raises positive values to at leastclosest_nfor HNSW. Other algorithms ignore positive values.Update Rust, Python, Go, and TypeScript bindings, existing Rust request constructors, and the similarity-search parameter documentation. Existing DSL queries continue to omit the field.
Validation: