Skip to content

docs: fix with_virtual_hosted_style_request typo #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thegamecracks wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: fix with_virtual_hosted_style_request typo #810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion obstore/python/obstore/_store/_aws.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ class S3Config(TypedDict, total=False):
For example, this might be set to `"http://localhost:4566:` for testing against a
localstack instance.

The `endpoint` field should be consistent with `with_virtual_hosted_style_request`,
The `endpoint` field should be consistent with `virtual_hosted_style_request`,
i.e. if `virtual_hosted_style_request` is set to `True` then `endpoint` should have
the bucket name included.

Expand Down
Loading