Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FsspecStore._lsbuilds its file entries fromlist_with_delimiter_async, whoseObjectMetaalready carrieslast_modifiedandversion, but keeps onlyname,size,typeande_tag. Sofs.ls(path, detail=True)gives no modification time, whilefs.info(path)on the same file giveslast_modifiedandversionfrom its HEAD request.The two disagree in practice:
ls(detail=True)users (file browsers, sync tools) see no date for any object, and fsspec's genericmodified()cannot be answered from a listing._infoanswers from the directory cache when the parent was listed, so whetherinfo()returnslast_modifieddepends on whether the parent was listed first.This adds both fields to each file entry, so a listed entry has the same fields
info()returns. It needs no extra request, since the values are already in the listing response. The timestamps differ only in precision: a listing reports milliseconds, while HEAD'sLast-Modifiedheader has whole seconds. Directory entries (common prefixes) are unchanged: they have no metadata of their own.The new test lists a file, clears the cache so
info()goes to the store, and checks that the two agree onversionand onlast_modifiedto within a second.