Repository navigation
Keep canvas headers clear of the Windows window controls - #1513
Merged
Merged
Conversation
On Windows and Linux the window controls sit over the right end of the top row. The tour's close button and the page bar's last buttons sat under them. Desktop now publishes how far the controls overlap each part, the top-right headers pad by it, and fullscreen header rows match the controls' height. Fixes #1490. Agent-Session: 9384a605-d9c3-4fb4-90ee-785315d819c8 Agent-Session: e35ee3f1-35bb-443a-a7fa-2d0fcb48c31e Agent-Session: b8a1d0cf-9b38-4aa4-b9f2-62aeab83bfb0
Agent-Session: 9384a605-d9c3-4fb4-90ee-785315d819c8 Agent-Session: e35ee3f1-35bb-443a-a7fa-2d0fcb48c31e Agent-Session: b8a1d0cf-9b38-4aa4-b9f2-62aeab83bfb0
sidkmenon
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows and Linux the window controls sit over the right end of the top row, and nothing in the canvas made room for them. The tour's close button, in the right-hand column and in a fullscreen tour, sat under them, so it could only be closed with Escape. The board's page bar lost its Discord, Report a bug, Diff settings and More buttons the same way.
Fixes #1490.
Changes
--review-window-controls-endon the editor and Ask parts: how far the titlebar's right cluster overlaps each part. It reuses the titlebar's zoom-aware width, so it holds at any zoom. It is 0 on macOS, and 0 on the editor part while the right column sits between it and the controls.Testing
pnpm lint, canvas and fork typechecks, fork tests, and the side panel browser tests.