Repository navigation
test(interactive): freeze C01–C12 complex acceptance and verify scripted Host scenarios - #12
Merged
Merged
Conversation
…ative evidence separation
…ogram signed Host and SQLite
… schema rejection and SQLite reopen
…ype to test real retry Pending
…l ChatGPT evidence with open native gates
Contributor
Author
C01–C12 独立源码与实测证据复审（2026-11-11）复审基线
逐项裁决
复审中发现的重要证据边界
审查结论与后续测试代码、协议用例与 CI 通过；复杂场景矩阵验收属于“协议层多数 PASS、真实模型 PARTIAL、原生 S13 BLOCKED”。当前没有从这些测试发现新的确定性 P0-A Core 缺陷。 |
…tentionally redacts State
…hides private State
Add current-main M6 scripted Host integration coverage, root-discovery fixtures, Linux cross-UID CI, and the full Interactive delivery roadmap. This is test/CI/documentation only and does not complete native-host C12/S13 or M6 final acceptance.
Add the reviewed Trusted Host V2 threat model, deployment profiles, security acceptance matrix, and explicit Phase 2 limitations. This is documentation-only: it does not implement Host isolation, Grok native provenance, Windows ACL enforcement, or Phase 3/4 runtime changes. F-02 and F-04 remain pending real validation; F-07 formal V0.3/V0.6-R5 conformance remains blocked. Merge does not authorize Phase 3 or claim C12/S13/M6 acceptance.
…dit plan Record independently validated Requirements V0.3 and Technical Design V0.6-R5 originals, limited Core PoC results and Phase 2 traceability roadmap. Reconcile the previously confirmed M1–M6 P0-A plan and existing M1–M5 implementation. Documentation only: no Core/API/Program ABI/Store schema changes, no Phase 3 authorization, no C12/S13 or full conformance PASS claim.
* docs(interactive): add source-backed T/R/S crosswalk and initial P0-A gap findings * docs(interactive): document Host/Public terminal State projection contract difference * docs(interactive): record async Store contract divergence from confirmed V0.6-R5 * docs(interactive): add Phase 2 R2 code-evidence review and R04 mutation findings * docs(interactive): link R04 independent regression PR and retrigger Phase 2 CI
…idence * docs(interactive): record local verification of PR 16 and 17 The report keeps the PR heads, commands, R04 failure output, the snapshot fix result, and the merge recommendation. Raw decisive logs are stored beside it. No product code changes. * docs(interactive): record that Actions for PR 16-19 are still queued The 13:15 +08 reconfirm keeps all four draft PRs unmerged. Run status is queued with an empty conclusion. That is not a matrix pass and not a proven Actions outage.
start() copied caller-owned State and startIntent only after loadInteractiveProgram resolved. That await yields even when the loader is already settled, so a caller could change both objects before the Checkpoint and startIntentHash were created. Copy both with the existing bounded canonical snapshot first, and preserve the initial-State capacity error. Later Store writes use those copies. Includes the R04 regression tests from PR #17.
rockyshi1993
marked this pull request as ready for review
November 12, 2026 08:23
rockyshi1993
commented
Nov 12, 2026
rockyshi1993
left a comment
rockyshi1993
left a comment
Contributor
Author
There was a problem hiding this comment.
Maintainer self-review completed against the current-main merge tree and exact PR HEAD. The eight unique files are documentation, fixtures, workflow example and tests only; no production Core/ABI/Store schema changes. The scripted C01-C04/C10-C11/C13-C20 assertions and evidence-tier limitations were reviewed. The recorded ChatGPT-response test now requires all five fixtures in normal CI; explicit FLOWKIT_C01_PREPARE=1 is the only incomplete-preparation path. Exact HEAD Actions run 43181841181 passed all 7/7 jobs, including 386/386 on the four OS/Node verify matrix cells. C12/S13 and native Host gates remain BLOCKED and are not claimed as passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Preserve the C01–C24 acceptance assets as test/documentation contributions, without changing production Core, Program ABI or Store schema.
Important evidence boundary
The five responses are recorded ChatGPT-authored fixtures, not live model API calls inside the CI job. GitHub tool identity is not provider-native session attestation. The test does not prove native Grok Build/Codex JS tools or cross-principal Host isolation. C12/S13 and applicable C22/C23 native-host gates remain BLOCKED.
The test recreates a temporary SQLite database per CI run and reopens it within that run; it does not share one physical DB across separate model turns/Actions runs.
C04's dedicated fixture uses retries=1 (two attempts); default retries=2 / three attempts is covered separately by main Coordinator tests.
Test gate
Normal CI requires all five recorded responses. The Pending-preparation path is available only when explicitly invoked with
FLOWKIT_C01_PREPARE=1; an incomplete fixture cannot silently pass normal CI.Verification
bede343d6226daa391f2857d737e5486cd567db1(refresh after the current review changes).Note
Medium Risk
The coordinator
start()snapshot change affects run creation and idempotency semantics at a concurrency-sensitive boundary; the rest is mostly tests and documentation.Overview
Adds C01–C24 interactive acceptance documentation and scripted Host test assets (fixtures,
c01-live-chatgptworkflow,m6-host.mjsworker bridge), and wirestests/integration/*.test.mjsintonpm testplus a new CI step that runstests/integration/m6-e2e.test.mjsunderFLOWKIT_M6_ISOLATION(withnpm cion the Host-isolation job).Fixes R04:
coordinator.start()now deep-copiesstateandstartIntentbefore the firstawait, so caller mutations after invokingstartno longer affect persisted checkpoints orstartKeyidempotency.Also commits a large Phase 2 / M6 evidence layer—local verification report, conformance audit R1/R2, formal source register, trusted-host V2 design/review/acceptance docs, and roadmap updates—without expanding Core ABI beyond the coordinator snapshot change.
Reviewed by Cursor Bugbot for commit b008d86. Bugbot is set up for automated code reviews on this repo. Configure here.