Repository navigation
fix(interactive): Stage 2 compiler/Skill configuration and binding contract parity - #10
Merged
rockyshi1993 merged 13 commits intoNov 11, 2026
Merged
Conversation
…and pinned Host binding versions
…g version contract
…rdinator stages before caching
…e bytes/identity each phase
…/missing Store bytes and metadata
…e verified LRU constraints
…verified cache contract
Contributor
Author
Stage 2 — 源码复审 / 精确 HEAD 验收(2026-11-11)受审提交: A. 集成契约修复:通过
B. Program 重复加载:先测量再优化,通过
C. 正式 CI / 安全与兼容性GitHub Actions 42954236755:精确 HEAD 7/7 completed/success。Ubuntu 24.04 / Windows 2025 × Node 22.13.0 / 24.22.1 各 357/357 PASS,0 FAIL,0 SKIP;打包、TS 类型、文档示例消费成功;website 和两个 Linux OS-user Host 隔离专项成功。 D. 复审裁决阶段二:PASS,可以按精确 HEAD 门禁 squash merge。 **未关闭的事项:**完整需求 V0.3、技术 V0.6-R5 的逐条正式契约核查仍受原文材料可获得性限制;M6 S13 真实模型宿主原生 JS 工具日志依然 BLOCKED,PR #7 继续保持 Draft/Open。不得以本阶段 CI 结果代替真实模型 Host 验收,不得发布、部署或提前开展 P0-B/P1/P2。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original agreed roadmap — Phase 2 (after S07, before S13)
Strict scope: unify Interactive static compilation with Standard's existing project root and Skill validation options; remove wrong rejection of shared
checkStepon pure Condition/Terminal; pin Host-provided binding version identities via existingpolicyHash(no new binding runtime); measure verified Program repeated-loading first, optimize only if justified.Scope
normalizeOptionsandresolveProjectRootforprojectRoot,skillsRoot,skillCheck,remoteSkillHosts. No importing source, no network fetching. Keep Interactive-only options output/featureStage and reject irrelevant Standard runtime/diagram options, preserving strict configuration contract.policy.bindingVersions, which the current Coordinator already fingerprints and checks across restarts. Functions and external Skill contents are NOT automatically hashed by FlowKit; Host is responsible for bumping versions when implementations/dependencies change. See new docs and regression tests.Validation and gates
tests/interactive/stage2-integration.test.mjs: nested package.json root parity, local/custom/remote Skills, integrity/allowlist, wrong options/accessors, pure vs AgentcheckStep, version-pinned resume mismatch and exact-State no-mutation.npm run verify+ docs, website, Linux OS security checks; independent review; squash merge only if all pass. M6 PR test(interactive): M6 P0-A integrated Host acceptance and cross-process verification #7 stays Draft pending real-model S13. No P0-B/P1/P2, Context, artifact providers, releases or deployment.Note
Medium Risk
Touches compile-time Skill policy, runtime Host binding checks, and Coordinator load paths where incorrect caching or policy handling could affect run integrity; mitigated by fail-closed checks and explicit negative tests.
Overview
Aligns Interactive P0-A static compilation with Standard:
compileInteractivenow acceptsprojectRoot,skillsRoot,skillCheck, andremoteSkillHostsvia the same discovery/normalization as Standard, while still rejecting unrelated Standard runtime options.Coordinator behavior is tightened for Stage 2: unused
runtime.checkStepis allowed only for Programs with no Agent bindings; Agent graphs still fail closed. Host binding drift is enforced through the existingpolicyHash(e.g.policy.bindingVersions), without a new API.Adds a per-coordinator 4-entry LRU of verified Programs. Every phase still re-reads Store artifacts, re-hashes bytes, and checks identity/policy—even on cache hits—with new regression tests for tamper/mismatch cases.
Documentation (
interactive-stage2-contract.md), type declarations, integration/cache tests, a diagnosticbench-interactive-load.mjs, and a Ubuntu/Node 24 CI measurement step complete the Stage 2 evidence path.Reviewed by Cursor Bugbot for commit 4559755. Bugbot is set up for automated code reviews on this repo. Configure here.