Skip to content

Removed traits/memory related features - #274

Open
sfreeman422 wants to merge 1 commit into
masterfrom
feature/remove-trais-memory
Open

Removed traits/memory related features#274
sfreeman422 wants to merge 1 commit into
masterfrom
feature/remove-trais-memory

Conversation

@sfreeman422

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings July 30, 2026 00:30
@sfreeman422 sfreeman422 changed the title Removed trais/memory related features Removed traits/memory related features Jul 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the previously implemented “personal context” (memory/traits) functionality across the frontend and backend, including the scheduled jobs, persistence layers, API endpoints, and related UI/tests, while updating docs and AI prompt behavior to no longer reference those features.

Changes:

  • Removed the frontend “Memories + Traits” page, hook, types, and associated unit tests; removed the navigation entry.
  • Removed backend memory/trait controllers, services, persistence, entities, jobs, and the /dashboard/personal-context endpoint; removed trait-context injection into AI prompts.
  • Updated JobService scheduling/tests and README references related to scheduled jobs and schema handling.

Reviewed changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
README.md Updates documentation around scheduled jobs/AI features; needs table to match removed memory job.
packages/frontend/src/pages/PersonalContextPage.tsx Removes the personal context UI page.
packages/frontend/src/pages/PersonalContextPage.spec.tsx Removes tests for the personal context UI page.
packages/frontend/src/pages/PersonalContextPage.model.ts Removes props model for the removed page.
packages/frontend/src/hooks/usePersonalContext.ts Removes the personal context data-fetching hook.
packages/frontend/src/hooks/usePersonalContext.spec.ts Removes tests for the removed hook.
packages/frontend/src/components/AppShell.tsx Removes nav entry and route rendering for the removed page.
packages/frontend/src/components/AppShell.spec.tsx Removes navigation test for the removed page.
packages/frontend/src/components/AppShell.model.ts Removes personal-context from the Page union.
packages/frontend/src/app.model.ts Removes shared frontend types for personal context response payload.
packages/backend/src/trait/trait.service.ts Removes trait service implementation.
packages/backend/src/trait/trait.service.spec.ts Removes tests for the removed trait service.
packages/backend/src/trait/trait.persistence.service.ts Removes trait persistence implementation.
packages/backend/src/trait/trait.persistence.service.spec.ts Removes tests for the removed trait persistence service.
packages/backend/src/trait/trait.job.ts Removes trait regeneration job.
packages/backend/src/trait/trait.job.spec.ts Removes tests for the removed trait job.
packages/backend/src/trait/trait.controller.ts Removes /traits Slack command controller.
packages/backend/src/trait/trait.controller.spec.ts Removes tests for the removed trait controller.
packages/backend/src/shared/db/models/Trait.ts Removes TypeORM Trait entity.
packages/backend/src/shared/db/models/SlackUser.ts Removes SlackUser relations/imports for memory/traits.
packages/backend/src/shared/db/models/Memory.ts Removes TypeORM Memory entity.
packages/backend/src/memory/memory.controller.ts Removes /memory Slack command controller.
packages/backend/src/memory/memory.controller.spec.ts Removes tests for the removed memory controller.
packages/backend/src/job.service.ts Removes memory/trait job scheduling; leaves only fun-fact/pricing/event-alert scheduling.
packages/backend/src/job.service.spec.ts Updates tests to match removed memory/trait scheduling.
packages/backend/src/index.ts Removes mounting of /memory and /traits controllers.
packages/backend/src/dashboard/dashboard.model.ts Removes dashboard model types for personal context payload.
packages/backend/src/dashboard/dashboard.controller.ts Removes /dashboard/personal-context endpoint implementation.
packages/backend/src/ai/memory/memory.persistence.service.ts Removes memory persistence service.
packages/backend/src/ai/memory/memory.persistence.service.spec.ts Removes tests for the removed memory persistence service.
packages/backend/src/ai/memory/memory.job.ts Removes daily memory extraction job implementation.
packages/backend/src/ai/memory/memory.job.spec.ts Removes tests for the removed memory extraction job.
packages/backend/src/ai/ai.service.ts Removes trait-context fetching/injection into AI prompt instructions.
packages/backend/src/ai/ai.service.spec.ts Removes tests for trait-context injection behavior.
packages/backend/src/ai/ai.constants.ts Removes memory/trait extraction constants/prompts and related system-instructions section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment on lines +260 to 264
Schema changes are managed by TypeORM using your configured synchronization settings.

### Scheduled Jobs

Most scheduled jobs run inside the backend Node.js process using `node-cron`. They are started automatically when the server connects to the database.
Comment on lines 61 to 65
/**
* Schedule all cron jobs on startup.
* Memory and trait jobs run daily at 3AM.
* Fun fact job runs daily at 9AM.
* Pricing job runs every hour at minute 10.
*/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants