clear 8 advisories, lockfile only - #2
Merged
Merged
Conversation
npm audit fix --package-lock-only: 14 -> 6, including the critical and 5 of 11 highs. package.json is byte-identical. the 6 left are all in metro and image-size under react-native, which is a devDependency and a peerDependency here - so they are build tooling, not something a consumer of this package installs. clearing them means moving react-native itself, which audit fix will only do with --force.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1.
npm audit fix --package-lock-only. 14 advisories → 6, clearing the criticaland 5 of 11 highs.
package.jsonis byte-identical.What is left, and why it matters less than the number suggests
All 6 remaining are in
metro,image-sizeand@react-native/community-cli-plugin— the React Native build toolchain.react-nativehere is a devDependency (^0.83.1) and a peerDependency(
>=0.70). It is not a runtime dependency of this package, so none of thesereach anyone installing
@detail-co/morph-text-native— a consuming app bringsits own React Native and its own metro. This is bundler tooling in this repo's
node_modules, not shipped code.Clearing them means moving
react-nativeitself, whichnpm audit fixwill onlydo with
--force. Not worth it for dev-only advisories in a library with no tests.Verification
package.jsonunchangednpm cifrom the new lockfilenpm run build(tsc)npm run typecheck(tsc --noEmit)No test run — this repo has no test script and no specs.
Note:
node -e "require('./dist/index.js')"fails withERR_MODULE_NOT_FOUNDon./MorphText, because the compiled output uses extensionless ESM imports. That ispre-existing and unrelated — Metro resolves them, plain Node does not. Flagging
it because it is a real packaging wrinkle worth fixing one day, not because this PR
touched it.
How to check this
This is a published library, not a deployed service, so there is no staging to
watch. The equivalent proof is a consuming build:
resolution error. That exercises the toolchain the remaining advisories live in.
MorphTextonce and confirm the animation runs — the whole surfaceof this package is one component.
version, so there is nothing for consumers to pick up; a release would be noise.