Skip to content

fix: 复审上游健康巡检 #213 的后续上游变更 - #228

Merged
yi-ge merged 1 commit into
fix/upstream-health-213from
fix/upstream-health-213-round2
Oct 28, 2026
Merged

yi-ge merged 1 commit into
fix/upstream-health-213from
fix/upstream-health-213-round2

Conversation

@yi-ge

@yi-ge yi-ge commented Oct 28, 2026

Copy link
Copy Markdown
Member

Summary

This is the follow-up round for #213. It reviews the upstream changes that landed after the 2026-10-19 review in #227. On the #227 baseline, the online check on 2026-10-27 reported 21 outdated pins, two stale holds (marketingskills and nuwa-skill) and the still-valid geo-optimizer hold. Each installed-scope diff was reviewed: the source path or the declared child paths, together with the root LICENSE/NOTICE/COPYING files. Each entry was then repinned or put on a reviewed hold. The per-entry decisions and compare links are in the new "Follow-up review (2026-10-27)" section of docs/upstream-health-213-remediation.md.

Stacked on #227, which is stacked on #222. Retarget to main once both merge.

Changes

  • 16 repins. These cover archify, banana, brainstorming, dingtalk-cli, follow-builders, frontend-slides, himalaya, impeccable, larksuite-cli, last30days, mattpocock-skills, planning-with-files(-zh), redbookskills, reverse-engineer-anything and taste-skill. For each one, entry.json and the catalog sidecar stay in sync: refs, compliance, review timestamps, observed versions, license evidence and compatibility requirements. No children were added or removed.
  • License and versions.
    • archify: upstream relicensed from MIT to Apache-2.0. The earlier MIT grants stay in LICENSE-MIT and NOTICE upstream.
    • Upstream versions recorded: banana 3.1.0, impeccable 4.8.0, last30days 3.31.0, planning-with-files 3.25.2 and reverse-engineer-anything revision 50 (opaque).
  • New or corrected external-dependency disclosures, following the repository policy:
    • banana: Python 3.11+ (was "Python 3"), Gemini billing including thinking tokens, Search-grounding retention, and local writes outside the workspace.
    • himalaya: the separately installed CLI, the operator's mail account and credentials, and send/delete without a built-in confirmation.
    • frontend-slides: the bundled PDF helper's Playwright and Chromium download, and the web-font hosts.
    • impeccable: the optional OpenAI image-API fallback (operator's key) and the unsandboxed, non-blocking hook. Downloads must now match SHA-256 digests shipped in the pinned skill.
    • last30days: the Bright Data CLI and credits for Amazon, the grok build audit and its cache, and the Arctic Shift archive.
    • reverse-engineer-anything: environment bundles on AgentEnv and Docker, Frida and debugger tooling, and the authorization gates for recording and instrumentation.
    • dingtalk-cli children: placeholder A2UI reply cards, AI-table roles and members, and standalone mind maps. mattpocock-skills' chief-of-staff summary now mentions its dated wiki folder.
  • Holds (upstream-health-hold.json):
    • marketingskills (refreshed): the referral promotion and the paid "Verified Partner" placements are unchanged at the new head. The new conversion-tracking child carries the same partner messaging.
    • nuwa-skill (refreshed): only the README banner was removed. SKILL.md still recommends the author's other projects whenever a request goes beyond the skill's scope.
    • agent-reach (new): the 1.6.0 rebuild defaults to an anti-detection browser for logged-in channels and copies site cookies from a connected Chrome. The installed SKILL.md is also an unrendered template.
    • wecom-cli (new): the new wecomcli-sheet scripts and workflow are adapted without attribution from the source-available xlsx skill in anthropics/skills, while the repository declares MIT.
    • geo-optimizer: unchanged and still valid.
  • Left out on purpose.

Review decisions worth a second look

  • agent-reach hold. Defaulting to a stealth browser is a judgment call. The review notes list what a bump would need to disclose if the default is accepted.
  • wecom-cli hold. The new C shim matches the market's own skills/xlsx except for two dashes in comments, and the recalculation macro matches it exactly. The market ships that content under its own third-party notice. The blocker is the unattributed MIT labeling, not the macro or shim behavior, which a later bump must disclose.
  • marketingskills new-skill. Holds cover only upstream-path-change and outdated, so the two new children stay actionable while the pin is held. The finding clears only when the sponsor content is removed or accepted, or when the checker lets a hold cover undeclared children.
  • Pre-existing, for the next review. At the current wecom-cli pin, wecomcli-pptx's anti-ai-slop.md names the source-available pptx skill in anthropics/skills as one source of a reworded checklist.

Validation

All run on 2026-10-27 against the reviewed heads:

  • Unit tests: 122 pass. By suite: i18n 19, catalog-metadata 51, collection generator 10, upstream health 42.
  • Validators: validate_catalog_metadata.py --require-complete, validate-i18n.py and translate.py --check pass with 0 errors. The 104 earlier warnings are unchanged, and none is new.
  • Collections: gen-collection-children.py --check reproduces all nine pinned collections.
  • Online health check on this branch: covered 111 entries, with nothing broken or unknown. Six held findings cover the five holds. The remaining actionable findings are marketingskills new-skill and the watch pin, which is current on main.
  • Online health check on this branch merged with main (aa6a1a6): covered 112 entries, with agent/video-director resolving again. Only the held findings and marketingskills new-skill remain. Two transient TLS failures in that run passed when rechecked individually.
  • git diff --check is clean.
  • Sensitive-token scan: passed (run privately by the maintainer).

Third-party programs and live account services were not executed.

Refs #213.

Review the upstream changes that landed after the 2026-10-19 round of #213. On the #227 baseline the online check reported 21 outdated pins, two stale holds (marketingskills, nuwa-skill) and the still-valid geo-optimizer hold. Review each installed-scope diff, then either repin or record a reviewed hold.

Repin 16 pointers to the reviewed heads: archify, banana, brainstorming, dingtalk-cli, follow-builders, frontend-slides, himalaya, impeccable, larksuite-cli, last30days, mattpocock-skills, planning-with-files, planning-with-files-zh, redbookskills, reverse-engineer-anything and taste-skill. Synchronize the sidecars: provenance and compliance refs, review timestamps, observed versions, license evidence and external-dependency disclosures. Record archify's relicensing from MIT to Apache-2.0, and the upstream versions of banana (3.1.0), impeccable (4.8.0), last30days (3.31.0), planning-with-files (3.25.2) and reverse-engineer-anything (revision 50). Newly disclosed: banana's Python 3.11+, Gemini billing and local writes; himalaya's separately installed CLI, mail credentials and send/delete without built-in confirmation; the frontend-slides PDF helper's browser download and its web-font hosts; impeccable's optional OpenAI image-API fallback and unsandboxed hook; the last30days Bright Data lane and grok build audit; reverse-engineer-anything's environment bundles on AgentEnv and Docker and its instrumentation gates; and dingtalk-cli child summaries for placeholder reply cards, AI-table roles and mind maps.

Refresh two holds and add two. marketingskills and nuwa-skill still carry sponsor or self-promotion in agent-facing content at the new heads. agent-reach now defaults to an anti-detection browser for logged-in channels, copies site cookies from a connected Chrome and installs an unrendered SKILL.md template. The new wecomcli-sheet content in wecom-cli is adapted without attribution from a source-available skill whose terms forbid redistribution, while the repository declares MIT. The geo-optimizer hold still applies, and the watch finding is again left to #221 on main. The manifest version is not bumped, for the same reason as #227. The per-entry review is recorded in `docs/upstream-health-213-remediation.md`.

Validation: 122 unit tests pass. Catalog metadata (--require-complete), i18n and translation-freshness checks pass with 0 errors and the same 104 warnings. All nine pinned collections reproduce. The online check covers 111 entries and finds nothing broken or unknown; apart from the held findings, only the marketingskills new-skill finding and the watch pin, which is current on main, remain. Merged with main, only the marketingskills new-skill finding remains. `git diff --check` is clean.

Stacked on #227.

Refs #213.
@github-actions
github-actions Bot requested a balanced review from Copilot October 28, 2026 01:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@yi-ge
yi-ge merged commit f0c2627 into fix/upstream-health-213 Oct 28, 2026
4 checks passed
@yi-ge
yi-ge deleted the fix/upstream-health-213-round2 branch October 28, 2026 02:39
yi-ge added a commit that referenced this pull request Oct 28, 2026
## Summary

This PR remediates the #213 upstream-health findings in two reviewed
rounds. Each installed-scope diff was reviewed: the source path or the
declared child paths, together with the root LICENSE/NOTICE/COPYING
files. Each entry was then repinned or put on a reviewed hold. Per-entry
decisions and compare links are in
`docs/upstream-health-213-remediation.md`, which covers the first review
and then the "Follow-up review (2026-10-27)" section.

- **Round 1 (2026-10-19):** 28 reported entries.
- **Round 2 (2026-10-27, squash-merged from #228):** the upstream
changes that landed after round 1.

#222 is now on `main`, and this branch has been updated with `main`.

## Changes

- **Repins.** Round 1 repinned 24 pointers. Round 2 repinned 16, some of
them again:
- Round 1: agent-reach, anatomy, archify, blog-chart, blog-repurpose,
brainstorming, dingtalk-cli, follow-builders, humanizer,
humanlayer-skills, impeccable, larksuite-cli, last30days,
mattpocock-skills, planning-with-files(-zh), redbookskills,
reverse-engineer-anything, systematic-debugging, taste-skill,
translate-book, video-use, wechatpay-skills, wecom-cli.
- Round 2: archify, banana, brainstorming, dingtalk-cli,
follow-builders, frontend-slides, himalaya, impeccable, larksuite-cli,
last30days, mattpocock-skills, planning-with-files(-zh), redbookskills,
reverse-engineer-anything, taste-skill.
- For each repin, `entry.json` and the catalog sidecar stay in sync:
refs, compliance, review timestamps, observed versions, license evidence
and compatibility requirements.
- **Three new collection children** with reviewed zh-CN/en-US summaries:
- `rpi` (humanlayer-skills): explicit invocation only. A real summary
replaces the upstream text, which only said to invoke it by name.
- `chief-of-staff` (mattpocock-skills): from upstream's in-progress
folder, manual invocation only.
- `wecomcli-pptx` (wecom-cli): needs the separately installed wecom-cli.
- **License.**
- archify: upstream relicensed from MIT to Apache-2.0. The earlier MIT
grants remain upstream in LICENSE-MIT and NOTICE.
  - humanlayer-skills: MIT license evidence and review dates recorded.
- **External-dependency disclosures**, following the repository policy:
  - brainstorming: visual-companion logo telemetry.
  - planning-with-files: automatic hooks and their Python 3 requirement.
  - archify: an opt-in global-rules edit.
  - taste-skill: public image APIs and CDN resources.
  - wechatpay-skills: knowledge-base sync.
  - banana: Python 3.11+, Gemini billing and data retention.
- himalaya: the separate CLI and mail credentials, and sending without
built-in confirmation.
  - frontend-slides: the Playwright/Chromium download.
- impeccable: the optional OpenAI image fallback and SHA-256-pinned
downloads.
  - last30days: Bright Data and the other optional providers.
  - reverse-engineer-anything: tooling and the authorization gates.
- Updated summaries for the dingtalk-cli and mattpocock-skills children.
- Unsupported domain and tool counts are removed from the dingtalk-cli
summary.
- **Reviewed holds** (`upstream-health-hold.json`):
- `geo-optimizer`: upstream moved the workflow outside the installed
subtree, so the new layout would install broken.
- `nuwa-skill`: SKILL.md recommends the author's other projects whenever
a request goes beyond the skill's scope.
- `agent-reach`: 1.6.0 defaults to an anti-detection browser that copies
site cookies from a connected Chrome.
- `wecom-cli`: new wecomcli-sheet content is adapted without attribution
from the source-available xlsx skill in anthropics/skills, while the
repository declares MIT.
- `marketingskills`: a referral promotion and paid "Verified Partner"
placements in agent-facing content. This hold went stale again on
2026-10-28; see below.
- **Manifest** goes to 1.5.18; #226 took 1.5.17 on `main`, and inventory
counts follow `main`. watch is left alone because #221 already pins it
on `main`.

## Review decisions worth a second look

- **archify proactive mode.** It edits the agent's global rules file
only after explicit user consent, and the edit is reversible. Disclosed
rather than held.
- **wechatpay-skills knowledge-base sync.** The sync can overwrite
installed files from the official CDN. This behavior predates this PR;
disclosed rather than held.
- **agent-reach and wecom-cli holds.** Both are judgment calls. The
review notes list what a later bump would need to disclose.
- **reverse-engineer-anything version.** Its upstream `metadata.version`
revision is recorded as an opaque version.

## Validation

Run on 2026-10-28 on this branch after merging `main` (`7a3ea30`, which
includes #226):

- Unit tests: 122 pass. By suite: i18n 19, catalog-metadata 51,
collection generator 10, upstream health 42.
- Validators: `validate_catalog_metadata.py --require-complete`,
`validate-i18n.py` and `translate.py --check` pass with 0 errors.
Warnings go from 105 on `main` to 103, and none are new.
- Collections: `gen-collection-children.py --check` reproduces all ten
pinned collections, including aws-agent-toolkit from #226.
- `git diff --check` is clean.
- Sensitive-token scan: passed for both rounds (run privately by the
maintainer). The `main` merge and the manifest bump add only generic
text.

Each round was also checked online against its reviewed heads; see the
remediation record. Third-party programs and live account services were
not executed.

## Not clean as of 2026-10-28

The online check on this branch covered 113 entries, and nothing is
broken. One transient TLS failure passed when rechecked individually.
Five `held` findings cover four holds: geo-optimizer counts twice,
nuwa-skill, agent-reach and wecom-cli once each. Still actionable:

- **marketingskills:** upstream moved again (`0cd9b3a`), so its hold is
`stale-hold`. The two undeclared children are still reported as
`new-skill`.
- **reverse-engineer-anything:** `outdated` against a newer head
(`40b9c03`).
- **agent/video-director:** `outdated` against a newer head (`4652b1d`).
It was added on `main` by #225.
- **aws-agent-toolkit:** `outdated` against a newer head (`655a323`). It
was added on `main` by #226.

These newer heads are not reviewed here. #213 stays open for the next
round.

Refs #213.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants