Repository navigation
docs: 更新 Control 应用市场入口与服务技能边界 - #181
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved findings cover the missing Registry entry, version wording, and incomplete external dependency and credential/lifecycle documentation.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds bilingual DesireCore Control marketplace documentation and clarifies native-app service boundaries.
Changes:
- Adds installation guides and README marketplace links.
- Updates service skills to version 1.0.4.
- Refreshes catalog metadata and translation information.
File summaries
| File | Summary |
|---|---|
skills/using-services/SKILL.zh-CN.md |
Documents native-app usage boundaries in Chinese. |
skills/using-services/SKILL.md |
Documents native-app usage boundaries. |
skills/using-services/catalog-metadata.v1.json |
Updates release metadata. |
skills/registering-services/SKILL.zh-CN.md |
Adds Chinese guidance against registering native apps as internal services. |
skills/registering-services/SKILL.md |
Adds native-app registration restrictions. |
skills/registering-services/catalog-metadata.v1.json |
Updates release metadata. |
README.md |
Adds the Control marketplace entry and documentation links. |
docs/desirecore-control.zh-CN.md |
Adds Chinese installation and lifecycle guidance. |
docs/desirecore-control.md |
Adds English installation and lifecycle guidance. |
Review details
Suppressed comments (4)
docs/desirecore-control.md:9
- The compatibility section says
app-install-manager >=1.4.0, but this guide presentsapp-install-manager 1.4.0as an exact requirement. That can incorrectly reject newer compatible versions; please match the PR description and the updated skill text by saying “1.4.0 or newer.”
On a compatible client, synchronize the catalog and search for **DesireCore Control** under **Market → Applications**. Verify version **1.4.0** before requesting installation. The listing requires native-app client support (minimum **10.0.169**) and the core Agent's **app-install-manager 1.4.0**. Catalog sync does not update the desktop client or Agent skills. An older client may omit the entry or require an upgrade; do not change its type or bypass receipt/version checks. Marketplace installation remains unavailable until the required client and skill are actually deployed.
docs/desirecore-control.md:15
- The application contract requires the local dashboard to receive the per-run
admin-tokenin addition to the Tunnel ID and runtime key. It also only reaps the locally owned tunnel-client child; it does not delete the Platform tunnel. This guide omits the required credential and can make users believe the remote tunnel is cleaned up, so document both distinctions and that the optional client is separately installed rather than bundled.
Start Control using the resource action or the exact independent command returned by the installer, then open its local dashboard in the system browser. Install the official tunnel client separately. Enter the Tunnel ID and runtime key locally, never in the marketplace installation conversation. Normal Control shutdown reaps only its owned tunnel, not DesireCore.
docs/desirecore-control.zh-CN.md:9
- 兼容性说明要求
app-install-manager >=1.4.0,但本指南把app-install-manager 1.4.0写成了精确版本,可能错误地拒绝更新的兼容版本。请与 PR 描述及已更新的技能正文一致,改为“1.4.0 或更新版本”。
在支持原生应用的 DesireCore 客户端中同步市场目录,然后在“市场 → 应用”搜索 **DesireCore Control**,核对版本 **1.4.0** 并发起安装。安装流程要求 `native-app` 客户端支持(条目标注最低 **10.0.169**)和应用安装管理技能 **1.4.0**。同步目录不会自动升级桌面客户端或核心智能体技能;旧版看不到条目或提示升级时,不应改类型、重建收据或绕过版本检查。客户端尚未发布或技能尚未更新时,市场一键安装仍不可用。
docs/desirecore-control.zh-CN.md:15
- 应用契约要求本机页面除 Tunnel ID 和运行 key 外还输入 Control 每次运行提供的
admin-token。正常退出只回收应用拥有的 tunnel-client 子进程,不会删除 Platform tunnel;当前说明遗漏了必需凭据,也可能让用户误以为远端隧道会被清理,请同时写明这两个边界,并说明客户端是单独安装而非随应用打包。
使用资源中的启动操作或安装器给出的准确独立命令启动 Control,在系统浏览器打开本机管理页。ChatGPT 隧道客户端需单独安装;Tunnel ID 和运行 key 由用户在本机页面提供,不能发到市场安装对话。正常退出 Control 时只清理自己的隧道,不停止 DesireCore。
- Files reviewed: 9/9 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
已按审查补齐中英文安装说明:技能要求统一为 1.4.0 或更新版本;明确官方客户端是可选且单独安装,per-run admin-token / MCP token / OpenAI key 分离;正常退出仅回收自有客户端进程,不删除 Platform Tunnel;增加组织/工作区权限、官方条款/账户费用、缺失或未就绪时不执行外部工具、不回退公开 CDP。 此前缺失的外部依赖现已发布:desirecore/registry#6 已合入 main,https://github.com/desirecore/registry/tree/main/entries/desirecore-control 可达;已通过 GitHub API 回读 manifest 并核对 1.4.0 tgz 的 SHA-256 与公开 Release 一致。核心安装技能 desirecore/agent-desirecore#11 也已合并。客户端兼容补丁为 desirecore/desirecore#3117(Draft);本文继续明确旧客户端不能仅刷新目录完成安装。 Validation after the documentation fixes: i18n/catalog check 0 errors, 129 existing warnings; no skill body/hash changes in this follow-up. The previously missing Registry entry is now published; desktop rollout is still explicitly not claimed. |
There was a problem hiding this comment.
🟢 Approval recommended
Review found only minor documentation nits and no blocking issues.
Review details
Suppressed comments (4)
Previously missed (2) — in code that hasn't changed since the last review.
docs/desirecore-control.md:9
- The authoritative Registry manifest/install guide require host Node.js >=22.22.2 and npm, but this checklist only names the client and app-install-manager versions. A user can satisfy the listed checks and still reach an unsupported installer; include the runtime prerequisite here.
docs/desirecore-control.zh-CN.md:9 - The authoritative Registry manifest/install guide require host Node.js >=22.22.2 and npm, but this checklist only names the client and app-install-manager versions. A user can satisfy the listed checks and still reach an unsupported installer; include the runtime prerequisite here.
docs/desirecore-control.md:11
- The Registry's current install guide runs
desirecore-cdp-mcp.cjs list --registryagainst an empty registry, which is an isolated discovery check rather than starting an empty instance. Calling this “empty-instance startup” overstates what installation verifies; describe the actual discovery self-check.
The installer uses the resolver-authorized fixed release URL and SHA-256, installs into an independent user directory, verifies the installed version and empty-instance startup, then records an App receipt. It does not start DesireCore, register internal MCP tools, enable control/tunnels, or install an autostart hook. Installed and running are distinct states.
docs/desirecore-control.zh-CN.md:11
- Registry 的当前安装指南是在空名录上执行
desirecore-cdp-mcp.cjs list --registry,这是隔离的实例发现自检,并不会启动空实例。“空实例启动”会夸大安装阶段实际验证的内容;这里应准确描述为发现自检。
安装器使用受信 resolver 的固定版本、下载地址和 SHA-256。默认安装在独立用户目录,验证包版本与空实例启动后才回写 App 安装收据。不会启动真实 DesireCore 实例,不创建内部 MCP,不默认启用控制、隧道或开机启动。应用安装成功和应用进程运行是两个状态。
- Files reviewed: 9/9 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
已核实并处理 Registry 外部依赖:正式 main 分支现有 entries/desirecore-control/manifest.json,GitHub Contents API 返回 200,blob SHA 为 fa59644680e98a658847eb48e80312ce2e27496f。 实际文件:https://github.com/desirecore/registry/blob/main/entries/desirecore-control/manifest.json 因此关于该条目不存在/404 的三条审查意见已不再成立。客户端最低版本仍明确标为 10.0.170,文档没有把尚待发布的客户端能力描述成现有旧版本可用。安装 Skill 最低版本统一为已合并且经 Windows 真机保留数据卸载复验的 1.5.2(desirecore/agent-desirecore#14)。 验证:全市场 i18n/catalog 校验 0 errors(129 项既有 warnings);两个变更技能的 translate --check 通过,diff 检查通过。范围仅通用产品说明、版本与翻译摘要,没有加入验收机器路径、用户身份或凭据。 The referenced Registry entry is now present on the authoritative main branch. The guide continues to require the matching client release and now points to installation Skill >=1.5.2, verified by a real Windows installation/uninstallation acceptance run. |
变更 / Changes
新增 Control 1.4.0 中英文市场安装指南及 README 应用入口,指向真正的应用数据源 desirecore/registry;同步 registering-services / using-services 到 1.0.4,明确 native-app 的对外 MCP 不可注册为内部服务。
Add bilingual marketplace documentation and update both service skills without duplicating an App as an MCP service. Fixed native application listing and lifecycle live in Registry; open-source implementation lives in desirecore-agent/desirecore-cdp-mcp.
兼容 / Compatibility
Requires native-app-aware desktop (catalog minimum 10.0.169) and app-install-manager >=1.4.0. Catalog publication does not upgrade the desktop or Agent.
验证 / Verification