Skip to content

fix(security): require Node 24.22.1, drop Node 22 support - #53

Merged
matin-deriv merged 1 commit into
masterfrom
fix/node-24-only
Nov 17, 2026
Merged

matin-deriv merged 1 commit into
masterfrom
fix/node-24-only

Conversation

@matin-deriv

Copy link
Copy Markdown
Collaborator

Summary

Moves the repo to Node 24.22.1 only, because that version carries an important security patch (CVE-2026-111497). This follows #52, which added the patched floors but still allowed Node 22.

  • engines.node (root, all 9 workspace packages, and the matching package-lock.json entries): ^22.23.4 || ^24.22.1 → ^24.22.1
  • CI build matrix: [22.23.4, 24.22.1] → [24.22.1]. .nvmrc and the setup_node default were already 24.22.1.
  • Docs (CLAUDE.md, docs/README.md, docs/architecture/architecture-analysis.md): Node 22 is no longer supported.

Breaking for contributors: anyone on Node 22 must switch with nvm install && nvm use. With engine-strict, npm will refuse to install on older versions.

⚠️ CI is red on master for an unrelated reason

npm ci fails in every job because package-lock.json is out of sync with package.json (Missing: eslint@8.57.1 from lock file, plus other eslint/@typescript-eslint packages). This has been the case since at least #47, and it also affected #49 and #52. Expect the same install failures here until the lockfile is regenerated in a separate PR.

Local verification on Node 24.22.1

Dependencies were installed with npm install --no-save --engine-strict, so the lockfile is unchanged apart from the engines lines.

  • tsc --noEmit passes for api, api-v2, utils and stores, the same projects CI checks.
  • Jest for api, api-v2, shared, stores, utils and components: 91/91 suites, 782 passed, 5 skipped. An earlier run had 1 failure that did not reproduce, so it looks flaky.
  • trader, core and reports tests and build:all were not run locally.

🤖 Generated with Claude Code

Node 24.22.1 carries an important security patch (CVE-2026-111497).
- engines.node ^22.23.4 || ^24.22.1 -> ^24.22.1 across all packages
- CI build matrix runs only on 24.22.1
- docs updated

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@matin-deriv
matin-deriv merged commit e3cc7c7 into master Nov 17, 2026
4 of 11 checks passed

This branch had an error being deployed

1 failed deployment
Preview — 11b0ea9d Deployed Nov 17, 2026 by matin-deriv via Tests - Core & Reports #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant