Repository navigation
Security: fix 22 vulnerabilities (0 critical, 10 high) - #50
Open
dependonme-github-app[bot] wants to merge 1 commit into
Open
dependonme-github-app[bot] wants to merge 1 commit into
dependonme-github-app[bot] wants to merge 1 commit into
Conversation
Pin follow-redirects 1.16.2, qs 6.16.1, fast-uri 3.1.9, serialize-javascript 7.1.3, pbkdf2 3.1.7, body-parser 1.20.9, compression 1.8.2, launch-editor 2.14.2, and source-map-js 1.2.2. Move postcss-selector-parser 6.x to 6.1.6. Bump @deriv-com/quill-ui to 1.24.13 and @deriv-com/quill-tokens to 2.0.32 so those packages no longer depend on @semantic-release/npm, which pulled a vulnerable npm CLI and undici. Override minimatch to 11.0.1 under @typescript-eslint/typescript-estree.
Deploying dtrader-template with
|
| Latest commit: |
f47d25f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c98d32ab.dtrader-template.pages.dev |
| Branch Preview URL: | https://security-auto-fix-20261110-0.dtrader-template.pages.dev |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
@deriv-com/quill-ui1.24.6 → 1.24.13 and@deriv-com/quill-tokens2.0.4 → 2.0.32 in@deriv/coreand@deriv/trader. quill-tokens 2.0.32 no longer depends on@semantic-release/npm, so the lockfile no longer installs thenpmCLI orundici6.29.0.minimatchunder@typescript-eslint/typescript-estreeis overridden to 11.0.1 (GHSA-g3hv-75wg-m249). minimatch 3.1.5 and 5.1.9, which are outside that advisory range, are unchanged.Code scanning and secret scanning are enabled and had no open alerts.
Unfixed
@deriv-com/translations1.4.0 (glob^10.3.12, exact pin in the workspaces) and 1.4.6 (glob^13, root^1.4.0). The first patched glob is 14.0.2. An override on@deriv-com/translationscollapses the exact 1.4.0 workspace copies onto 1.4.6, which does not satisfy those pins.@deriv-com/translations1.6.1 and 1.7.1 pin glob 14.0.2, and they also require peeri18next>=23 andreact-i18next>=14. This repo is on i18next 22.5.1 and react-i18next 11.18.6.Requires human action
Upgrade
@deriv-com/translationsto at least 1.6.1 together withi18next>=23 andreact-i18next>=14, then retest the trading screens. That is the parent bump that clears GHSA-3g3m-2fjr-6pw4 and the remaining minimatch copies. deepmerge still has no upstream patch.No hardcoded secrets were found. Nothing to rotate.
Build and test results
npm ci --strict-peer-depssucceeded with npm 11.6.2.npm audit: 0 critical, 0 high, 3 moderate (translations / glob / minimatch), 16 low (deepmerge and its dependents).tsc --noEmitpassed forpackages/api,packages/api-v2,packages/utils, andpackages/stores.npm run test:stylelintpassed.npm run test:eslint-allpassed (warnings only, 0 errors).npx jest --all --ci --runInBand --shard=i/8).npm run build:allpassed (webpack warnings only) with a local placeholderOAUTH_CLIENT_ID.postcss-selector-parser7.1.6 moved to 7.2.0 while updating the vulnerable 6.x line to 6.1.6. That 7.x line was not in the advisory range (<6.1.5).