Repository navigation
Let indexing recover by itself after a database hiccup - #74
Merged
Merged
Conversation
If indexing a block stopped halfway, for example on a database error, the transactions already stored were treated as done when the block was indexed again, and their balance changes were silently lost. - The indexer now marks a block as in progress before its first write and clears the mark after its last. If anything fails in between, the next run first rebuilds the address balances from the stored transactions. - A normal shutdown now waits up to 15 seconds for the block being indexed and stops between blocks, so a restart during a deploy no longer leaves half a block behind. If the block does not finish in time, startup recovery rebuilds as before. - Each new block costs two small extra writes to the sync state. - Checked with database tests that interrupt indexing at each step (a transaction write, the balance write, the block write, a shutdown) and compare every address balance with the expected one; each part of the fix was undone once to confirm that a test fails without it.
If the database failed at the wrong moment, the indexer could stay blocked until the next restart, and a database reconnect started a second copy of the indexer and of the Telegram bot. - The indexing lock now expires: if its holder has shown no sign of life for 10 minutes (each indexed block and each step of an address rebuild counts), the next run takes it over and first rebuilds the address balances. Before, a lock left behind by a failed run made every later run fail until a restart. - When recording an indexing error fails as well, the original error is still logged and the run ends normally. - Starting the indexer or the Telegram bot a second time, as happens after a database reconnect, no longer starts a second copy. - Checked with database tests for an expired lock, a recent lock, a failed error record, a long rebuild and repeated starts; each part of the fix was undone once to confirm that a test fails without it.
minuszka
marked this pull request as ready for review
November 14, 2026 06:35
minuszka
added a commit
to minuszka/explorer
that referenced
this pull request
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the database failed at the wrong moment, the indexer could stay blocked until the next restart, and a database reconnect started a second copy of the indexer and of the Telegram bot.