Skip to content

Keep address balances correct when indexing a block is interrupted - #73

Merged
minuszka merged 1 commit into
defcon-project:mainfrom
minuszka:fix/a2a-interrupted-block
Nov 14, 2026
Merged

minuszka merged 1 commit into
defcon-project:mainfrom
minuszka:fix/a2a-interrupted-block

Conversation

@minuszka

Copy link
Copy Markdown
Contributor

If indexing a block stopped halfway, for example on a database error, the transactions already stored were treated as done when the block was indexed again, and their balance changes were silently lost.

  • The indexer now marks a block as in progress before its first write and clears the mark after its last. If anything fails in between, the next run first rebuilds the address balances from the stored transactions.
  • A normal shutdown now waits up to 15 seconds for the block being indexed and stops between blocks, so a restart during a deploy no longer leaves half a block behind. If the block does not finish in time, startup recovery rebuilds as before.
  • Each new block costs two small extra writes to the sync state.
  • Checked with database tests that interrupt indexing at each step (a transaction write, the balance write, the block write, a shutdown) and compare every address balance with the expected one; each part of the fix was undone once to confirm that a test fails without it.

If indexing a block stopped halfway, for example on a database error, the transactions already stored were treated as done when the block was indexed again, and their balance changes were silently lost.

- The indexer now marks a block as in progress before its first write and clears the mark after its last. If anything fails in between, the next run first rebuilds the address balances from the stored transactions.
- A normal shutdown now waits up to 15 seconds for the block being indexed and stops between blocks, so a restart during a deploy no longer leaves half a block behind. If the block does not finish in time, startup recovery rebuilds as before.
- Each new block costs two small extra writes to the sync state.
- Checked with database tests that interrupt indexing at each step (a transaction write, the balance write, the block write, a shutdown) and compare every address balance with the expected one; each part of the fix was undone once to confirm that a test fails without it.
@minuszka
minuszka merged commit 1f62e42 into defcon-project:main Nov 14, 2026
1 check passed
@minuszka
minuszka deleted the fix/a2a-interrupted-block branch November 14, 2026 06:15
minuszka added a commit to minuszka/explorer that referenced this pull request Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant