Skip to content

macdeploy: package the macOS app bundle under one name - #463

Merged
minuszka merged 1 commit into
defcon-project:v22.1.xfrom
minuszka:fix/macos-app-bundle-name
Nov 15, 2026
Merged

minuszka merged 1 commit into
defcon-project:v22.1.xfrom
minuszka:fix/macos-app-bundle-name

Conversation

@minuszka

Copy link
Copy Markdown
Contributor

The macOS app bundle could not be packaged because its settings and scripts still used Dash's name; it now builds, opens and stops on a real Mac. Tested on GitHub's macOS runners; the release archive stays the same.

The build puts the GUI binary in Defcon-Qt.app/Contents/MacOS/Defcon-Qt,
but the Info.plist still named the executable Dash-Qt, and the deploy
script and both signing helpers looked for Dash-Qt.app. make deploy
stopped with a traceback, and a bundle macOS starts by its plist could
not have found its binary. The plist also registered the dash: URI
scheme, while the wallet reads defcon: links.

The deploy script now takes the binary from the bundle's own
CFBundleExecutable and refuses, with a plain error, a bundle whose plist
and binary disagree; the deployed bundle and its zip keep the source
bundle's name. The plist names Defcon-Qt and registers defcon:, and the
signing helpers and the notarization notes use Defcon-Qt.app. A bundle
deployed against a dynamic Qt now also gets the SVG image format and
icon engine plugins, the counterparts of what a static build links in;
without them the window has no logo. The bundle identifier stays as it
is, since the notification handler reports the same one.

A new check in the CI gate keeps the build, the plist and the deploy
script on one name and the deployed plugins in step with the static
imports. The release's macOS archive of plain binaries is unchanged.

Tested on GitHub's Intel macOS runners: a Linux cross-build with the
pinned SDK and make deploy, its bundle and a native build started and
stopped on macOS 15.
@minuszka
minuszka marked this pull request as ready for review November 15, 2026 20:21
@minuszka
minuszka merged commit 25fb8eb into defcon-project:v22.1.x Nov 15, 2026
11 checks passed
@minuszka
minuszka deleted the fix/macos-app-bundle-name branch November 15, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant