Repository navigation
macdeploy: package the macOS app bundle under one name - #463
Merged
minuszka merged 1 commit intoNov 15, 2026
Merged
Conversation
The build puts the GUI binary in Defcon-Qt.app/Contents/MacOS/Defcon-Qt, but the Info.plist still named the executable Dash-Qt, and the deploy script and both signing helpers looked for Dash-Qt.app. make deploy stopped with a traceback, and a bundle macOS starts by its plist could not have found its binary. The plist also registered the dash: URI scheme, while the wallet reads defcon: links. The deploy script now takes the binary from the bundle's own CFBundleExecutable and refuses, with a plain error, a bundle whose plist and binary disagree; the deployed bundle and its zip keep the source bundle's name. The plist names Defcon-Qt and registers defcon:, and the signing helpers and the notarization notes use Defcon-Qt.app. A bundle deployed against a dynamic Qt now also gets the SVG image format and icon engine plugins, the counterparts of what a static build links in; without them the window has no logo. The bundle identifier stays as it is, since the notification handler reports the same one. A new check in the CI gate keeps the build, the plist and the deploy script on one name and the deployed plugins in step with the static imports. The release's macOS archive of plain binaries is unchanged. Tested on GitHub's Intel macOS runners: a Linux cross-build with the pinned SDK and make deploy, its bundle and a native build started and stopped on macOS 15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS app bundle could not be packaged because its settings and scripts still used Dash's name; it now builds, opens and stops on a real Mac. Tested on GitHub's macOS runners; the release archive stays the same.