Skip to content

Run three more unit suites in the CI gate - #458

Merged
minuszka merged 1 commit into
defcon-project:v22.1.xfrom
minuszka:test/excluded-unit-suites-triage
Nov 15, 2026
Merged

minuszka merged 1 commit into
defcon-project:v22.1.xfrom
minuszka:test/excluded-unit-suites-triage

Conversation

@minuszka

@minuszka minuszka commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

CI now runs three unit test suites it used to skip: two tests expected Bitcoin's coin limit or a peer without a version and now use this chain's values, the third passed as is. Tested on our CI server; five suites still await triage.

transaction_tests treated Bitcoin's 21,000,000 coins as too much
money, a valid amount on this chain, and denialofservice_tests left
its peers at version 0, which the protocol floor disconnects, so a
peer below the discouragement threshold was dropped anyway. Both now
use this chain's values, and tx_valid checks the limit itself;
validation_chainstate_tests passed as it was. Five suites still
await triage. Tested locally.
@minuszka
minuszka marked this pull request as ready for review November 15, 2026 14:37
@minuszka
minuszka merged commit 7215a95 into defcon-project:v22.1.x Nov 15, 2026
11 checks passed
@minuszka
minuszka deleted the test/excluded-unit-suites-triage branch November 15, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant