Repository navigation
Run three more unit suites in the CI gate - #458
Merged
minuszka merged 1 commit intoNov 15, 2026
Merged
Conversation
transaction_tests treated Bitcoin's 21,000,000 coins as too much money, a valid amount on this chain, and denialofservice_tests left its peers at version 0, which the protocol floor disconnects, so a peer below the discouragement threshold was dropped anyway. Both now use this chain's values, and tx_valid checks the limit itself; validation_chainstate_tests passed as it was. Five suites still await triage. Tested locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI now runs three unit test suites it used to skip: two tests expected Bitcoin's coin limit or a peer without a version and now use this chain's values, the third passed as is. Tested on our CI server; five suites still await triage.