Repository navigation
Keep PSBTs with a signed BLS input readable - #457
Merged
minuszka merged 1 commit intoNov 15, 2026
Merged
Conversation
walletprocesspsbt with finalize=false stored a BLS signature as a partial signature, a record no PSBT reader accepts with a BLS key, so the node refused its own PSBT at the next step. A signed BLS input is now finalized either way; ECDSA inputs stay partial. Tested locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where signing a PSBT with a BLS key without finalizing gave a PSBT the node itself could not read back. Such inputs are now finalized right away. Tested locally.