Repository navigation
Conversation
Keep each CoinJoin client alive while RPC, GUI and shutdown callbacks use it. Move mixing state to the wallet to avoid the keypool lock inversion, and initialize enable/autostart settings without restarting other wallets. Backport Dash Core #7259 (e118d0cdd8cbd807691e18b5e69f180ab8922165), adapted to this fork's wallet manager and existing RPC responses. Upstream authors: Konstantin Akimov, UdjinM6, PastaClaw and Pasta. Add lifetime, lock-order and initialization regressions, plus legacy and descriptor CoinJoin RPC coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Backport Dash Core #7259 to improve
CoinJoin client lifetime and wallet initialization.
What was done?
Use scoped callbacks for CoinJoin client access, keep mixing state in the
wallet, and initialize enable/autostart settings for the added wallet.
Adapt the upstream change to this fork's existing wallet manager and RPC
responses. Update the Qt CoinJoin interface calls and add lifetime,
lock-order, initialization and RPC regressions.
Original upstream authors: Konstantin Akimov, UdjinM6, PastaClaw and Pasta.
How Has This Been Tested?
395f5dea, committed as4463055a, exact tree1d43edc5.DEBUG_LOCKORDER, includingthe existing unit gate (781 cases), compiled Qt suites, strict LSan and
its canary, configure and no-wallet regressions.
and descriptor CoinJoin RPC runs both passed.
Existing unit exclusions and Qt minimal-platform skips were retained.
Six pre-existing source-lint failures remain identical to the baseline
only after path normalization. Native platform and combined frontend-r20
validation are outside these results.
The unchanged patch merges cleanly with upstream
0decee29(#313).Hosted PR CI must validate that combined tree. The frontend r20 requires
its own integration checks after the Core merge.
Breaking Changes
None. Existing RPC responses and wallet data formats are preserved.
Checklist