Skip to content

wallet: fix CoinJoin client lifetime and initialization - #314

Merged
minuszka merged 1 commit into
defcon-project:v22.1.xfrom
minuszka:fix/upstream-coinjoin-lifetime-group4
Oct 20, 2026
Merged

minuszka merged 1 commit into
defcon-project:v22.1.xfrom
minuszka:fix/upstream-coinjoin-lifetime-group4

Conversation

@minuszka

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Backport Dash Core #7259 to improve
CoinJoin client lifetime and wallet initialization.

What was done?

Use scoped callbacks for CoinJoin client access, keep mixing state in the
wallet, and initialize enable/autostart settings for the added wallet.
Adapt the upstream change to this fork's existing wallet manager and RPC
responses. Update the Qt CoinJoin interface calls and add lifetime,
lock-order, initialization and RPC regressions.

Original upstream authors: Konstantin Akimov, UdjinM6, PastaClaw and Pasta.

How Has This Been Tested?

  • Approved patch 395f5dea, committed as 4463055a, exact tree 1d43edc5.
  • Full local Linux CI: 8/8 stages passed with DEBUG_LOCKORDER, including
    the existing unit gate (781 cases), compiled Qt suites, strict LSan and
    its canary, configure and no-wallet regressions.
  • Complete named functional gate: 30/30 variants passed; separate legacy
    and descriptor CoinJoin RPC runs both passed.
  • Same-tree prefix-transport and detached-signing helper regressions passed.
  • Actual commit-script, message, whitespace and file-mode checks passed.

Existing unit exclusions and Qt minimal-platform skips were retained.
Six pre-existing source-lint failures remain identical to the baseline
only after path normalization. Native platform and combined frontend-r20
validation are outside these results.

The unchanged patch merges cleanly with upstream 0decee29 (#313).
Hosted PR CI must validate that combined tree. The frontend r20 requires
its own integration checks after the Core merge.

Breaking Changes

None. Existing RPC responses and wallet data formats are preserved.

Checklist

  • I have performed a self-review of my own code
  • I have commented the non-obvious code paths
  • I have added or updated relevant unit and functional tests

Keep each CoinJoin client alive while RPC, GUI and shutdown callbacks use
it. Move mixing state to the wallet to avoid the keypool lock inversion,
and initialize enable/autostart settings without restarting other wallets.

Backport Dash Core #7259 (e118d0cdd8cbd807691e18b5e69f180ab8922165),
adapted to this fork's wallet manager and existing RPC responses.
Upstream authors: Konstantin Akimov, UdjinM6, PastaClaw and Pasta.

Add lifetime, lock-order and initialization regressions, plus legacy and
descriptor CoinJoin RPC coverage.
@minuszka
minuszka merged commit f0693e3 into defcon-project:v22.1.x Oct 20, 2026
4 checks passed
@minuszka
minuszka deleted the fix/upstream-coinjoin-lifetime-group4 branch October 20, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant