Skip to content

Bound InstantSend queues and peer-message intake - #312

Merged
minuszka merged 1 commit into
defcon-project:v22.1.xfrom
minuszka:fix/upstream-resource-group2
Oct 19, 2026
Merged

minuszka merged 1 commit into
defcon-project:v22.1.xfrom
minuszka:fix/upstream-resource-group2

Conversation

@minuszka

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Several peer-message intake paths retain or process data before applying their
command-specific resource limits. This backport aligns those paths with the
corresponding upstream Dash handling.

What was done?

  • Bound InstantSend inputs and pending queues, retaining verified local locks
    at capacity and avoiding unnecessary eviction for duplicate entries.
  • Ignore receive-paused peers when deciding whether the socket loop has work.
  • Bound governance vote signatures on network reads while preserving disk,
    hash and outbound serialization.
  • Apply full-session CoinJoin wire bounds and retain per-entry limits, with
    signing-session state and participant checks.
  • Apply the upstream DSTX peer-accounting scores and add focused regressions.

Backports from dashpay/dash: 0a681dbb, cb6afcbe, dashpay/dash#7440, dashpay/dash#7419 and dashpay/dash#7347.
Original upstream author: pasta. Adapted to this fork's existing interfaces.

Validation

  • Exact reviewed tree ce721785, local commit d421e0db.
  • Full local CI: all 8 stages passed, including the existing unit gate
    (772 cases), every compiled Qt suite, strict LSan/canary, configure and
    no-wallet regressions.
  • Named functional gate: 30/30 passed; separate p2p_dstx.py passed.
  • Helper regressions on the same tree: 24 prefix-transport and 12 detached
    signing cases passed.
  • Focused before/after controls cover the changed queue and wire boundaries.
  • All 4 actual commit checks passed: commit scripts, message, whitespace,
    and file names/modes.

This is local Linux validation; hosted PR CI remains pending.

Limits

The socket test covers the polling decision; no CPU improvement is claimed.
The mempool-callback transfer branch has static coverage and shares the tested
queue logic, but has no dedicated runtime test. No native platform or live
network validation is claimed.

Backport the upstream Dash resource limits for InstantSend queues,
governance vote signatures, CoinJoin messages and socket receive handling.
Keep verified local locks ahead of pending verification work at capacity
and avoid evicting another entry when the lock is already queued.

Apply the upstream DSTX peer-accounting scores and add boundary,
serialization and peer-accounting regressions.

Upstream Dash commits: 0a681dbb and cb6afcbe.
Upstream PRs: dashpay/dash#7440, dashpay/dash#7419,
dashpay/dash#7347.
Original upstream author: pasta <pasta@dashboost.org>
@minuszka
minuszka merged commit 714aeca into defcon-project:v22.1.x Oct 19, 2026
4 checks passed
@minuszka
minuszka deleted the fix/upstream-resource-group2 branch October 19, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant