Skip to content

The overview deadline rides the open fast window, and the coalescer's comments say window, not silence - #1465

Merged
WaylandYang merged 1 commit into
devfrom
fix/overview-deadline-rides-fast-window
Oct 30, 2026
Merged

WaylandYang merged 1 commit into
devfrom
fix/overview-deadline-rides-fast-window

Conversation

@WaylandYang

Copy link
Copy Markdown
Contributor

Fixes #1463. Corrects the comments behind #1462.

Test: the overview deadline rides the open fast window instead of flushing it early. It fails with the old flush. The existing overview timing test now allows for the extra SETTLE_MS.

🤖 Generated with Claude Code

… comments say window, not silence

When the overview timer fired it flushed the fast layer, so keys still inside their 300 ms window went out early and a steady push paid one extra fast refetch per overview window. It now only pushes into the fast layer. With no fast window open the overview lands up to SETTLE_MS later. Reconnect and unmount still flush through flushAll, so prefix folding is unchanged.

The window starts at the first event and does not reset (#1311), which the comments described as silence.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Wayland Yang <wayland@Mac.bbrouter>
@WaylandYang
WaylandYang merged commit c34dd04 into dev Oct 30, 2026
6 checks passed
@WaylandYang
WaylandYang deleted the fix/overview-deadline-rides-fast-window branch October 30, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant