Repository navigation
The overview deadline rides the open fast window, and the coalescer's comments say window, not silence - #1465
Merged
Conversation
… comments say window, not silence When the overview timer fired it flushed the fast layer, so keys still inside their 300 ms window went out early and a steady push paid one extra fast refetch per overview window. It now only pushes into the fast layer. With no fast window open the overview lands up to SETTLE_MS later. Reconnect and unmount still flush through flushAll, so prefix folding is unchanged. The window starts at the first event and does not reset (#1311), which the comments described as silence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Wayland Yang <wayland@Mac.bbrouter>
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1463. Corrects the comments behind #1462.
SETTLE_MSlater (3.3 s instead of 3 s). Reconnect and unmount still go throughflushAll, so prefix folding is unchanged.Test:
the overview deadline rides the open fast window instead of flushing it early. It fails with the old flush. The existing overview timing test now allows for the extraSETTLE_MS.🤖 Generated with Claude Code