Repository navigation
The embedding ceiling test measures overlap rather than database write overhead on a slow machine - #1459
Merged
WaylandYang merged 2 commits intoOct 29, 2026
Conversation
…e overhead on a slow machine Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Aschenbath <Aschenbath@users.noreply.github.com>
7 tasks done
WaylandYang
approved these changes
Oct 29, 2026
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Thanks — the peak and overlap assertions are unchanged and a serialized gate still fails. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1131 at review.
the_embedding_gate_is_never_held_beyond_its_ceilingsends twelve batches through a fake embedding server that answers each one after a fixed delay. It makes three assertions: the peak number of batches in flight is at mostEMBED_JOBS(4), at least two batches overlap, and total time is under three quarters of fully serial. With a 150 ms delay that bound is 1.35 s, and the fixed cost of writing 192 chunk vectors to PostgreSQL takes a large share of it. In #1131's local full run (Linux x86_64, 2 CPUs, PostgreSQL 16/pgvector under proot), the test took 1.51 s and failed even though peak and overlap were both correct. The gate was fine; the database was slow.The delay is now 400 ms, so waiting on the fake network accounts for most of the elapsed time. The bound is still three quarters of serial (3.6 s against 4.8 s): an ideal run is three rounds of four, about 1.2 s, so a regression that serializes the gate still fails. The peak and overlap assertions, which are what actually check the ceiling, are unchanged. The test now takes about 0.75 s longer.
Not run locally on this branch: I don't build Rust on this machine, so CI's
cargo test --workspaceis the check.