Repository navigation
fix(node): preserve detached archives across failed starts - #439
Open
Floating-Y wants to merge 1 commit into
Open
Floating-Y wants to merge 1 commit into
Floating-Y wants to merge 1 commit into
Conversation
Signed-off-by: danwood <118035379+Floating-Y@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A detached Create could unpack its archive successfully and then fail during boot. The leftover overlay mount or Firecracker disk blocked subsequent retries, while automatic reaping could delete the only recovery archive.
Rebuild failed local state from the retained archive before retrying Create, preserving the original prepare/boot errors and protecting live or snapshotted sandboxes. Automatic reaping releases local resources and networking while keeping the archive. Explicit Destroy still removes the archive and preserves the user volume.
Validation:
Coverage: Firecracker uses real ext4 data, prepare/teardown, and tar/zstd I/O. gVisor prepare/mount/teardown and both backends' boot/exec are simulated. The production Create and automatic reaping paths are exercised.
Real guest startup and network resource release were not exercised (net_index=None). Retries rebuild from the saved archive, discarding local writes made during the failed startup.