Repository navigation
fix(node): preserve overlay xattrs across detach and restore - #438
Open
Floating-Y wants to merge 1 commit into
Open
Floating-Y wants to merge 1 commit into
Floating-Y wants to merge 1 commit into
Conversation
Floating-Y
marked this pull request as ready for review
November 2, 2026 03:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Deleting a template directory and recreating it as an empty directory causes overlayfs to mark it opaque. The detach archive and restore extraction did not preserve these extended attributes, so deleted template files reappeared after restore.
This is separate from #369, which prevents source data deletion when archiving fails.
Changes
trusted.overlay.*anduser.overlay.*during both tar creation and extraction.Validation
-D warnings, andgit diff --checkpassed.Limitations
Full gVisor and Firecracker boot end-to-end tests were not run. Existing archives that have already lost overlay attributes cannot be repaired by this change.