Repository navigation
fix(recipes): select native video recorders - #521
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native recipe recordings failed because the provider supplied a recorder only for web. Bind Android targets to the existing Expo screenrecord backend and iOS simulators to simctl. Physical iOS remains explicitly unsupported.
Validation on mini: failing regression first; 14 applicable provider tests pass, including shared-host execution and assigned-target refusal. The unrelated Expo CLI source check needs Expo dependencies absent from the tooling checkout. The added tooling dependency matches the existing framework versions.
Approved recorder-only physical proof at e9e8940 produced a 3.8-second H.264 clip at 1080x2400 through this provider factory. Source SHA verified, device lease released, no ticket dispatch, app actions, build or service restart. This proves recorder wiring and capture; it makes no Audiolab UI claim.