Fix custom chrome window drag regions - #65
Open
Febers wants to merge 1 commit into
Open
Conversation
Make the custom window chrome explicitly drag the window from empty header space, non-interactive status labels, and review chips while keeping interactive controls out of the drag region. Add focused coverage for draggable and non-draggable chrome hit targets. Co-authored-by: TRAE CLI <noreply@bytedance.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
./scripts/build_ghosttykit.sh.xcodebuild -project Zentty.xcodeproj -scheme Zentty -destination 'platform=macOS' -configuration Debug -derivedDataPath /private/tmp/zentty-derived CODE_SIGNING_ALLOWED=NO buildpassed.xcodebuild -project Zentty.xcodeproj -scheme Zentty -destination 'platform=macOS' -configuration Debug -derivedDataPath /private/tmp/zentty-derived CODE_SIGNING_ALLOWED=NO -only-testing:ZenttyLogicTests/WindowChromeViewTests testpassed: 60 tests, 0 failures.Notes
A full
xcodebuild ... testrun completed compilation and integration tests, but had unrelated existing/environment failures outside this change area, including path-shortening expectations, programmatic resize layout assertions, a shortcuts preview key-recording assertion, and an OpenCode theme sync assertion.WindowChromeViewTestspassed in the full run and in the focused rerun.