Skip to content

client/rpcserver: fix cert handling in handlePostBond #3624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Share-coin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

client/rpcserver: fix cert handling in handlePostBond #3624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions client/rpcserver/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,6 +1115,20 @@ func handlePostBond(s *RPCServer, msg *msgjson.Message) *msgjson.ResponsePayload
exchCfg := exchInf[form.Addr]
if exchCfg == nil {
// Not already registered.
//
// form.Cert arrives as a JSON string - bwctl's optionalTextFiles
// pre-reads a cert filepath argument into the certificate's raw
// content before sending it, same as handleGetDEXConfig does
// above (which explicitly converts to []byte for this reason).
// core.PostBondForm.Cert is typed any, so it unmarshals as a Go
// string rather than []byte here, and core.parseCert then
// treats that string as a filepath and tries to re-read the PEM
// content as if it were a filename, which always fails. Convert
// to []byte here, matching handleGetDEXConfig, so parseCert
// takes its []byte branch instead.
if certStr, ok := form.Cert.(string); ok && certStr != "" {
form.Cert = []byte(certStr)
}
var err error
exchCfg, err = s.core.GetDEXConfig(form.Addr, form.Cert)
if err != nil {
Expand Down