feat(settings): say what each column means, instead of mapping them - #6728
Open
viktormarinho wants to merge 1 commit into
Open
feat(settings): say what each column means, instead of mapping them#6728viktormarinho wants to merge 1 commit into
viktormarinho wants to merge 1 commit into
Conversation
The screen this direction set out to remove, replaced rather than deleted. An org whose board is its own now sees its Jira columns with one question each: what does this mean to Studio. Most mean nothing, and leaving them that way is the answer rather than a gap to fill — which is the whole difference from the mapping it replaces. That asked a team to restate, lane by lane, something their tracker already knew; this asks the one thing it cannot know. Same place in settings, and the mapping is untouched for an org on Studio's board: its lanes are ours and Jira has no idea what they mean, so there is nothing to ask there. Third of the three UIs this work has owed. Automations and the board mode are still tool-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The screen this whole direction set out to remove — replaced, not deleted.
An org whose board is its own now sees its Jira columns in Settings → Tasks → Jira, with one question each: what does this mean to Studio? Options are "Nothing special" (the default), "Under review", and "Archive".
Most columns mean nothing, and leaving them that way is the answer — not a gap to fill. That is the whole difference from the mapping it replaces. The mapping asked a team to restate, lane by lane, something their tracker already knew, and every unmapped column was a silent hole. This asks the one thing Jira cannot tell us: which of their columns is where review happens, and which retires a card.
Same place in settings. The mapping is untouched for an org on Studio's board — its lanes are ours and Jira has no idea what they mean, so there is nothing to ask there.
This is the third of three UIs this work has owed. Automations (#6690) and the board mode (#6698) are still tool-only, and I would not call the debt cleared.
How did you verify your code works?
bun run check0 errors — which also proves the pt-BR dictionary mirrors en, since thesatisfiescontract makes a missing key a compile error, and six new keys landed on both sides.bun run lintat baseline,knipclean,fmt:checkclean.apps/web/src/views+ the board layout: 184 pass / 4 fail, identical to baseline measured by stashing and re-running. Those four (PublishPolicyFieldand neighbours) are the known order-dependent set at that scope.Not verified, and this is the weak part of this PR:
QueryClientProviderandProjectContextProvider, which by this repo's own rule makes it e2e rather than unit — and there is no e2e for settings. So the honest position is: the types line up and the pieces it composes are each covered elsewhere, but this specific screen has been reasoned about, not exercised. It wants a look before anyone relies on it.useTaskBoardItemsto get the columns, because that read is the only source of a column'srole. On a settings page that is heavier than it needs to be; it is cached and shared with the board itself, so the cost is usually zero, but a dedicated read would be cleaner.in_reviewis settable and still read by nothing (flagged in feat(task-board): let a column say what it means #6718) — so choosing it today records an intent that nothing acts on yet.Screenshots/Demonstration
Not captured — see above. The visible change is the mapping table swapped for a column-and-role table, only for an org with
org_board_columnson, of which there are none.How to Test
org_board_columnson and sync so the columns exist. The same card should now read "What each column means" and list the Jira columns.Migration Notes
None. Client-only; the tool it calls shipped in #6718.
Review Checklist
Summary by cubic
Replaces the Jira column mapping screen in Settings → Tasks → Jira with a per-column role picker, only for orgs whose board is their own. Most columns mean nothing to Studio, and "Nothing special" is now the honest default instead of a silent unmapped gap.
useSetColumnRole, which callsTASK_BOARD_COLUMN_ROLE_SETand invalidates the shared board read.satisfiescontract.in_reviewis settable but nothing reads it yet, so choosing it records intent nothing acts on.Written for commit 2070687. Summary will update on new commits.