chore(test): fix command to create generic-for-e2e vmclass#2393
Merged
diafour merged 4 commits intoMay 27, 2026
Conversation
hardcoretime
force-pushed
the
chore/test/fix-generic-e2e-vmclass-creation-command
branch
from
e4b4452 to
6fedba3
Compare
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
- rename defaultVMClassName to requiredVMClassName for clarity - extract defaultClassAnnotation as constant to avoid duplication - refactor loop to single pass through vmclasses - extract getVMClassName helper function to package level - add comments explaining variables purpose Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
hardcoretime
force-pushed
the
chore/test/fix-generic-e2e-vmclass-creation-command
branch
from
874eb4c to
8f8a115
Compare
hardcoretime
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix command suggestion in default vmclass precheck.
Why do we need it, and what problem does it solve?
Command was wrong.
What is the expected result?
Dev cluster admin can create copy of vmclass/generic and run e2e tests.
Checklist
Changelog entries