Skip to content

chore: bump node base image to 24.22.3 - #1980

Merged
LautaroPetaccio merged 1 commit into
mainfrom
chore/node-24.22.3
Nov 12, 2026
Merged

LautaroPetaccio merged 1 commit into
mainfrom
chore/node-24.22.3

Conversation

@LautaroPetaccio

Copy link
Copy Markdown
Contributor

Summary

  • Re-pins node:24-alpine in the Dockerfile from sha256:6a1c190e… (Node 24.22.1) to the tag's current digest sha256:116b800c…, which ships the 24.22.3 security release for amd64 and arm64.
  • The tag text stays 24-alpine.

Re-pins node:24-alpine to the digest that ships the 24.22.3 security release on amd64 and arm64.

@decentraland-bot decentraland-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR changes one line: it re-pins the node:24-alpine base image to a new digest. I checked the new digest sha256:116b800c…85f5 against the Docker Hub registry. It is the current digest for both node:24-alpine and node:24.22.3-alpine, and it is a multi-arch index (linux/amd64, linux/arm64 and others), so the PR description is accurate.

Runtime risk is low:

  • A patch bump within Node 24 / Alpine leaves the musl/Alpine major version unchanged.
  • The production install has no native addons to rebuild. pg is pure JS, and ssh2/cpu-features only come in through the dev dependency testcontainers.
  • The image satisfies engines.node >=24.0.0, .nvmrc (24) and CI (24.x).
  • The title chore: … and the branch chore/node-24.22.3 follow ADR-6.

Findings

  • [P2] Dockerfile:1: The tag still says 24-alpine. Writing node:24.22.3-alpine@sha256:116b… would make the pinned version readable without querying the registry. The digest still decides which image is used. Optional.
  • [P2] .github/dependabot.yml: Only the npm ecosystem is configured, so this digest will go stale silently until someone bumps it by hand again. Consider adding a package-ecosystem: docker entry.
  • [P2] .github/workflows/build.yml:17,47: CI tests on 24.x (latest patch) while the image ships a fixed 24.22.3. This drift is minor and was already there before this PR.

The test-content check was still running when I reviewed. It should pass before merge.

No P0/P1 issues. Approving.


Reviewed by Jarvis 🤖 · Requested by Lautaro Petaccio (<@U025WCHLMN3>) via Slack

@LautaroPetaccio
LautaroPetaccio merged commit 6c56f8a into main Nov 12, 2026
4 checks passed
@LautaroPetaccio
LautaroPetaccio deleted the chore/node-24.22.3 branch November 12, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants