fix(dub): skip empty cues in translation readiness - #2663
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[Medium risk] Changes translation readiness logic for dubbed content. The PR appears safe to merge on the reviewed behavior. SummaryThe PR aligns cached translation readiness with the progress indicator by excluding empty spoken cues, while keeping jobs with no spoken cues incomplete. It adds regression tests and updates the dubbing documentation and changelog. Reviews (1) · Last reviewed commit: "fix(dub): skip empty cues in translation..." |
|
All contributors on this pull request have signed the VoiceStudio CLA. Thank you! |
|
recheck |
Summary
Translation progress excludes cues with empty spoken text, but cached translation readiness includes them. A target can therefore show complete progress while an empty cue blocks readiness and causes retranslation. Both checks should use the same nonempty spoken cue set; an all-empty job should remain incomplete.
Closes #2662.
Changes
Type
Testing
Hosted CI audit at 2026-10-06T12:35:20.584679+00:00: no failing latest checks; required CLA passes. All latest reported checks completed successfully. No upstream merge performed.
Native shared helper regression: 1 failed and 3 passed before; all 4 pass after. Active Electron call sites inspected; no live translation/render requests.
git diff --checkand the repository changelog style gate pass.Focused JavaScript tests used Node 24.19.0 and a reused Vitest 5.0.1 runtime; this repository pins Vitest 4.1.11. No full build qualification is claimed.
Full backend suites and
bun run check:electronwere not run locally. The human CLA signature is registered and the required CLA status passes; hosted results are reported separately below.Checklist
package.json,pyproject.toml,backend/core/version.py, and lockfilestests/fixtures/omnivoice_data/still loads green on thesmoke-matrixCI job (macOS + Windows + Linux)Release cadence
VoiceStudio ships continuous-to-main — no release candidates, no soak windows.
Every merged PR is immediately part of rolling source (
main) and Docker:latest. Electron artifact rehearsals validate desktop packages without publishing.Version bumps require owner approval; validated releases are tagged from
mainand published explicitly under the release checklist.
Users who want stability install an Electron release or pin Docker
:stable.