Repository navigation
fix(dub): carry rounded timestamp seconds into minutes - #2661
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[Medium risk] Fixes timestamp rounding in the dubbing timeline display. No merge-blocking issue was identified in the changed code. SummaryThe PR rounds elapsed time to tenths before splitting it into minutes and seconds, then uses that formatter in the Electron dubbing timeline.
Reviews (1) · Last reviewed commit: "fix(dub): carry rounded timestamp second..." |
|
All contributors on this pull request have signed the VoiceStudio CLA. Thank you! |
|
I have read the VoiceStudio CLA 1.0 and I hereby sign it. |
|
Recheck |
1 similar comment
|
Recheck |
Summary
Formatting a timestamp such as 59.96 seconds calculates the minute before rounding the remaining seconds, producing 0:60.0 instead of 1:00.0. The same rounding issue occurs at later minute boundaries in shared labels and the active timeline formatter. Round to tenths before splitting minutes and seconds. This affects display labels, not audio or export timing.
Closes #2660.
Changes
Type
Testing
Hosted CI audit at 2026-10-06T12:35:20.584679+00:00: no failing latest checks; required CLA passes. All latest reported checks completed successfully. No upstream merge performed.
Focused shared formatter case fails before and passes after, covering minute/hour rounding boundaries; 5 unrelated utility cases skip. No React DOM/native UI or full typecheck run. Display-only fix.
git diff --checkand the repository changelog style gate pass.Focused JavaScript tests used Node 24.19.0 and a reused Vitest 5.0.1 runtime; this repository pins Vitest 4.1.11. No full build qualification is claimed.
Full backend suites and
bun run check:electronwere not run locally. The human CLA signature is registered and the required CLA status passes; hosted results are reported separately below.Checklist
package.json,pyproject.toml,backend/core/version.py, and lockfilestests/fixtures/omnivoice_data/still loads green on thesmoke-matrixCI job (macOS + Windows + Linux)Release cadence
VoiceStudio ships continuous-to-main — no release candidates, no soak windows.
Every merged PR is immediately part of rolling source (
main) and Docker:latest. Electron artifact rehearsals validate desktop packages without publishing.Version bumps require owner approval; validated releases are tagged from
mainand published explicitly under the release checklist.
Users who want stability install an Electron release or pin Docker
:stable.