Repository navigation
fix(agents): honor deadlines for queued completions - #2659
rudycelekli wants to merge 2 commits into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[Medium risk] Changes how the agent bridge handles request timeouts. The PR appears safe to merge based on the reviewed changes. SummaryThe PR makes queued agent completions respect their HTTP deadlines without starting overlapping CLI calls. The latest change classifies requests with too little time left to start as HTTP 504 and adds a native HTTP regression test. Reviews (2) · Last reviewed commit: "fix(agents): classify queued start expir..." |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
All contributors on this pull request have signed the VoiceStudio CLA. Thank you! |
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
1 participant
Summary
CLI completions are serialized behind the active runner. A queued HTTP request can remain waiting beyond its own timeout while an earlier completion is still active. HTTP waiting should respect each request deadline while the real task retains its place in the serial runner queue, preventing overlapping CLI execution.
Closes #2658.
Changes
Type
Testing
Hosted CI audit at 2026-10-06T12:35:20.584679+00:00: no failing latest checks; required CLA passes. Some checks remain pending; no all-green claim.
Owned loopback HTTP/deferred callback regression: 1 failed and 4 passed before; all 5 pass after. No real CLI/provider completion requests.
git diff --checkand the repository changelog style gate pass.Focused JavaScript tests used Node 24.19.0 and a reused Vitest 5.0.1 runtime; this repository pins Vitest 4.1.11. No full build qualification is claimed.
Full backend suites and
bun run check:electronwere not run locally. The human CLA signature is registered and the required CLA status passes; hosted results are reported separately below.Additional queue-start regression uses the real native HTTP server request/body-end handshake: public code returns 502 before the fix; all 6 bridge tests pass after consistent 504 classification.
Checklist
package.json,pyproject.toml,backend/core/version.py, and lockfilestests/fixtures/omnivoice_data/still loads green on thesmoke-matrixCI job (macOS + Windows + Linux)Release cadence
VoiceStudio ships continuous-to-main — no release candidates, no soak windows.
Every merged PR is immediately part of rolling source (
main) and Docker:latest. Electron artifact rehearsals validate desktop packages without publishing.Version bumps require owner approval; validated releases are tagged from
mainand published explicitly under the release checklist.
Users who want stability install an Electron release or pin Docker
:stable.