Skip to content

fix(recording): close meter contexts when setup fails - #2655

Open
rudycelekli wants to merge 1 commit into
debpalash:mainfrom
rudycelekli:fix/microphone-meter-setup-cleanup-20261006
Open

rudycelekli wants to merge 1 commit into
debpalash:mainfrom
rudycelekli:fix/microphone-meter-setup-cleanup-20261006

Conversation

@rudycelekli

@rudycelekli rudycelekli commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Both microphone meter implementations allocate an AudioContext before building the graph and scheduling a frame. A failure in source creation, graph connection or frame scheduling can escape without closing that context. The recording hook tolerates optional meter errors, so retrying can retain unused contexts. Failed setup should close its context before propagating the error.

Closes #2654.

Changes

  • Close AudioContexts on setup failures in both shared and active renderer implementations.
  • Synchronize relevant documentation and add a quiet credited Unreleased changelog entry.
  • No new UI strings or locale keys; maintained version files are unchanged.

Type

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor
  • 📝 Documentation
  • 🧪 Tests
  • 🔧 CI / Build
  • 🚀 Release prep

Testing

  • Hosted CI audit at 2026-10-06T12:35:20.584679+00:00: no failing latest checks; required CLA passes. All latest reported checks completed successfully. No upstream merge performed.

  • Web Audio facade regressions for both implementations: 6 failed and 4 passed before; all 10 pass after. No hardware microphone or native browser run.

  • git diff --check and the repository changelog style gate pass.

  • Focused JavaScript tests used Node 24.19.0 and a reused Vitest 5.0.1 runtime; this repository pins Vitest 4.1.11. No full build qualification is claimed.

  • Full backend suites and bun run check:electron were not run locally. The human CLA signature is registered and the required CLA status passes; hosted results are reported separately below.

Checklist

  • I've tested this locally
  • Every commit author has signed the CLA (the CLA check tells you how)
  • I've updated relevant documentation (if applicable)
  • No local machine paths, logs, or personal env details in this PR
  • Maintained version files are in sync (if an owner-requested bump): root package.json, pyproject.toml, backend/core/version.py, and lockfiles
  • If this PR changes runtime behavior, the regression fixture at tests/fixtures/omnivoice_data/ still loads green on the smoke-matrix CI job (macOS + Windows + Linux)

Release cadence

VoiceStudio ships continuous-to-main — no release candidates, no soak windows.
Every merged PR is immediately part of rolling source (main) and Docker
:latest. Electron artifact rehearsals validate desktop packages without publishing.
Version bumps require owner approval; validated releases are tagged from main
and published explicitly under the release checklist.
Users who want stability install an Electron release or pin Docker :stable.

Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: debpalash/VoiceStudio/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c3af258d-e6a1-4c3d-8483-25d0b2b4612c
📥 Commits

Reviewing files that changed from the base of the PR and between 286f46b and 021cdad.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • docs/audio-quality.md
  • electron/src/renderer/src/lib/audio/recorder.ts
  • electron/src/shared/utils/audioInput.js
  • electron/src/shared/utils/audioInput.test.js
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Retrigger

[Medium risk] Adds error handling to microphone metering setup.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR closes microphone-meter AudioContexts when synchronous graph setup or initial frame scheduling fails, adds regression tests for both implementations, and updates the documentation and changelog.

Reviews (1) · Last reviewed commit: "fix(recording): close meter contexts whe..."

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

All contributors on this pull request have signed the VoiceStudio CLA. Thank you!

@rudycelekli

Copy link
Copy Markdown
Contributor Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microphone meter setup failures leave an AudioContext open

1 participant