Skip to content

fix(stories): release longform readers on every exit - #2653

Open
rudycelekli wants to merge 1 commit into
debpalash:mainfrom
rudycelekli:fix/longform-stream-cleanup-20261006
Open

rudycelekli wants to merge 1 commit into
debpalash:mainfrom
rudycelekli:fix/longform-stream-cleanup-20261006

Conversation

@rudycelekli

@rudycelekli rudycelekli commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The longform stream consumer can leave its response reader locked when an event callback throws or when rendering completes before the response closes. An abort can also leave a pending read waiting. The active renderer throws on render error events. Each exit should cancel unread data and release the reader lock.

Closes #2652.

Changes

  • Cancel and release response readers on callback failures, completion and abort.
  • Synchronize relevant documentation and add a quiet credited Unreleased changelog entry.
  • No new UI strings or locale keys; maintained version files are unchanged.

Type

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor
  • 📝 Documentation
  • 🧪 Tests
  • 🔧 CI / Build
  • 🚀 Release prep

Testing

  • Hosted CI audit at 2026-10-06T12:35:20.584679+00:00: no failing latest checks; required CLA passes. All latest reported checks completed successfully. No upstream merge performed.

  • Native Node Web Streams regressions: 3 failed and 5 passed before; all 8 pass after. No live backend/model rendering.

  • git diff --check and the repository changelog style gate pass.

  • Focused JavaScript tests used Node 24.19.0 and a reused Vitest 5.0.1 runtime; this repository pins Vitest 4.1.11. No full build qualification is claimed.

  • Full backend suites and bun run check:electron were not run locally. The human CLA signature is registered and the required CLA status passes; hosted results are reported separately below.

Checklist

  • I've tested this locally
  • Every commit author has signed the CLA (the CLA check tells you how)
  • I've updated relevant documentation (if applicable)
  • No local machine paths, logs, or personal env details in this PR
  • Maintained version files are in sync (if an owner-requested bump): root package.json, pyproject.toml, backend/core/version.py, and lockfiles
  • If this PR changes runtime behavior, the regression fixture at tests/fixtures/omnivoice_data/ still loads green on the smoke-matrix CI job (macOS + Windows + Linux)

Release cadence

VoiceStudio ships continuous-to-main — no release candidates, no soak windows.
Every merged PR is immediately part of rolling source (main) and Docker
:latest. Electron artifact rehearsals validate desktop packages without publishing.
Version bumps require owner approval; validated releases are tagged from main
and published explicitly under the release checklist.
Users who want stability install an Electron release or pin Docker :stable.

Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: debpalash/VoiceStudio/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9eb73c34-b82d-4782-8f20-221da9887796
📥 Commits

Reviewing files that changed from the base of the PR and between 286f46b and 7921a80.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • docs/expressive-speech.md
  • electron/src/shared/test/longformStream.test.js
  • electron/src/shared/utils/longformStream.js
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Retrigger

[Medium risk] Fixes stream cleanup when reading longform content stops.

No merge-blocking issue was established in the changed code.

Summary

The PR adds cancellation and reader-lock cleanup to the shared longform stream consumer on completion, callback failure, and abort. It adds native-stream regression tests and updates the changelog and streaming documentation.

Reviews (1) · Last reviewed commit: "fix(stories): release longform readers o..."

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

All contributors on this pull request have signed the VoiceStudio CLA. Thank you!

@rudycelekli

Copy link
Copy Markdown
Contributor Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stories stream reader remains locked when callbacks throw or rendering stops

1 participant