Repository navigation
fix(desktop): retire stale blank-window probes - #2649
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[Medium risk] Fixes blank-window recovery to not reload after navigation. The PR appears safe to merge based on the reviewed changes. SummaryThe PR retires blank-window probe results after main-frame navigation, guard disposal, or window closure, and adds lifecycle regression tests and documentation. Reviews (1) · Last reviewed commit: "fix(desktop): retire stale blank-window ..." |
|
All contributors on this pull request have signed the VoiceStudio CLA. Thank you! |
|
recheck |
|
Thanks for the report and the work on this, @rudycelekli. The problem in #2648 is fixed on |
Summary
A blank-window DOM probe can resolve after a replacement main-frame navigation starts or commits, or after the guard stops or the window closes. The old result can then trigger recovery against a newer page or disposed window. Results should be checked against current navigation generation and window liveness before recovery.
Closes #2648.
Changes
Type
Testing
Hosted CI audit at 2026-10-06T12:35:20.584679+00:00: no failing latest checks; required CLA passes. All latest reported checks completed successfully. No upstream merge performed.
Electron lifecycle facade regression: 4 failed and 5 passed before; 10 pass after, including an added child-frame control. No native Electron UI run.
git diff --checkand the repository changelog style gate pass.Focused JavaScript tests used Node 24.19.0 and a reused Vitest 5.0.1 runtime; this repository pins Vitest 4.1.11. No full build qualification is claimed.
Full backend suites and
bun run check:electronwere not run locally. The human CLA signature is registered and the required CLA status passes; hosted results are reported separately below.Checklist
package.json,pyproject.toml,backend/core/version.py, and lockfilestests/fixtures/omnivoice_data/still loads green on thesmoke-matrixCI job (macOS + Windows + Linux)Release cadence
VoiceStudio ships continuous-to-main — no release candidates, no soak windows.
Every merged PR is immediately part of rolling source (
main) and Docker:latest. Electron artifact rehearsals validate desktop packages without publishing.Version bumps require owner approval; validated releases are tagged from
mainand published explicitly under the release checklist.
Users who want stability install an Electron release or pin Docker
:stable.