Skip to content

fix(desktop): retire stale blank-window probes - #2649

Closed
rudycelekli wants to merge 1 commit into
debpalash:mainfrom
rudycelekli:fix/blank-window-probe-lifecycle-20261006
Closed

rudycelekli wants to merge 1 commit into
debpalash:mainfrom
rudycelekli:fix/blank-window-probe-lifecycle-20261006

Conversation

@rudycelekli

@rudycelekli rudycelekli commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

A blank-window DOM probe can resolve after a replacement main-frame navigation starts or commits, or after the guard stops or the window closes. The old result can then trigger recovery against a newer page or disposed window. Results should be checked against current navigation generation and window liveness before recovery.

Closes #2648.

Changes

  • Retire asynchronous probes after main-frame navigation, stop or destruction; retain child-frame controls.
  • Synchronize relevant documentation and add a quiet credited Unreleased changelog entry.
  • No new UI strings or locale keys; maintained version files are unchanged.

Type

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor
  • 📝 Documentation
  • 🧪 Tests
  • 🔧 CI / Build
  • 🚀 Release prep

Testing

  • Hosted CI audit at 2026-10-06T12:35:20.584679+00:00: no failing latest checks; required CLA passes. All latest reported checks completed successfully. No upstream merge performed.

  • Electron lifecycle facade regression: 4 failed and 5 passed before; 10 pass after, including an added child-frame control. No native Electron UI run.

  • git diff --check and the repository changelog style gate pass.

  • Focused JavaScript tests used Node 24.19.0 and a reused Vitest 5.0.1 runtime; this repository pins Vitest 4.1.11. No full build qualification is claimed.

  • Full backend suites and bun run check:electron were not run locally. The human CLA signature is registered and the required CLA status passes; hosted results are reported separately below.

Checklist

  • I've tested this locally
  • Every commit author has signed the CLA (the CLA check tells you how)
  • I've updated relevant documentation (if applicable)
  • No local machine paths, logs, or personal env details in this PR
  • Maintained version files are in sync (if an owner-requested bump): root package.json, pyproject.toml, backend/core/version.py, and lockfiles
  • If this PR changes runtime behavior, the regression fixture at tests/fixtures/omnivoice_data/ still loads green on the smoke-matrix CI job (macOS + Windows + Linux)

Release cadence

VoiceStudio ships continuous-to-main — no release candidates, no soak windows.
Every merged PR is immediately part of rolling source (main) and Docker
:latest. Electron artifact rehearsals validate desktop packages without publishing.
Version bumps require owner approval; validated releases are tagged from main
and published explicitly under the release checklist.
Users who want stability install an Electron release or pin Docker :stable.

Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: debpalash/VoiceStudio/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2c05b1d0-49d7-479a-9b97-75c6eb705754
📥 Commits

Reviewing files that changed from the base of the PR and between 286f46b and 0d187e0.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • docs/electron-repair.md
  • electron/src/main/blank-window-guard.test.ts
  • electron/src/main/blank-window-guard.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Retrigger

[Medium risk] Fixes blank-window recovery to not reload after navigation.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR retires blank-window probe results after main-frame navigation, guard disposal, or window closure, and adds lifecycle regression tests and documentation.

Reviews (1) · Last reviewed commit: "fix(desktop): retire stale blank-window ..."

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

All contributors on this pull request have signed the VoiceStudio CLA. Thank you!

@rudycelekli

Copy link
Copy Markdown
Contributor Author

recheck

@debpalash

Copy link
Copy Markdown
Owner

Thanks for the report and the work on this, @rudycelekli. The problem in #2648 is fixed on main by 6cfd4bcc (merged in #2673), so I'm closing this pull request as already fixed. It will ship in v0.5.7. Reporter credit stays in the changelog.

@debpalash debpalash closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delayed blank-window probes can act on a replaced or disposed Electron page

2 participants