Repository navigation
fix(workbook): honor stable column IDs in structural edit guards - #95
Merged
debpalash merged 2 commits intoOct 13, 2026
Merged
Conversation
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workbook formulas resolve exact column IDs before display names. The structural edit guards did not use that precedence: an unrelated column named
sourcecould block deletion or rename even when{source}referenced a different column whose ID wassource.This fix keeps exact stable ID references authoritative during deletion, rename and whole-config replacement. Real display-name dependencies and ambiguous aliases remain blocked, so an edit cannot silently redirect those references.
Verification
Native fork validation: https://github.com/rudycelekli/OpenGTM/actions/runs/38406866232, source head
6ffa03b45a24c28eaa9c4c36d8ed393c6a1cc102.Prepared with AI assistance and independently reviewed before publication. No live provider calls or production data were used for the regression fixtures.