Repository navigation
fix(web): show "No results." in virtualized empty tables - #93
Merged
Merged
Conversation
The virtualized branch was chosen whenever virtualization was on, because an empty virtual-item array is truthy, so the empty-state row never rendered. On the Leads page a company filter matching nothing showed a blank table. Signed-off-by: debpalash <debash67@outlook.in> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while browser-verifying the react-table v9 migration (#81/#88); this predates it.
DataTablepicked the virtualized body wheneverenableVirtualization && virtualRows, andvirtualRowsis[](truthy) when there are no rows, so the "No results." row never rendered. On/leads(virtualized by default), filtering companies to something with no match showed a blank table under "0 rows".data-table.tsx: requirerows.lengthfor the virtualized branch so empty tables fall through to the empty state.test_lead_selection_browser.py/ fixture: also mount a default (virtualized)DataTablewith no data and assert "No results." renders. Fails without the fix, passes with it.🤖 Generated with Claude Code