Skip to content

feat(cli): persist the selected Tailscale daemon - #24

Merged
vriesd merged 5 commits into
mainfrom
feat/saved-socket
Oct 24, 2026
Merged

vriesd merged 5 commits into
mainfrom
feat/saved-socket

Conversation

@vriesd

@vriesd vriesd commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Why

Selecting a Tailscale daemon currently requires an environment export or an edited executable. Save the socket selection in Tailmux so a fresh shell uses the same daemon.

What changed

  • Add offline --config show, --config set socket PATH, and --config reset socket commands.
  • Feed one effective socket and source into diagnostics, peer discovery, and SSH. An explicit environment override takes precedence.
  • Validate bounded config data and file metadata. Serialize writers, verify publication, and back up current-version data before reset.

Scope

  • Covers persistent socket selection and installed-client configuration preservation.
  • Explicit recovery of modified installations and release distribution follow in later phases. Public installation remains on v0.2.3.

Blast Radius

Connections without an environment override now read the saved configuration. Invalid saved data stops the connection before daemon access. Help, version, and local configuration commands work offline.

Verification

  • bash scripts/tests/run.sh full passed before the final publication cleanup correction.
  • After that correction, configuration, runtime, and doctor suites passed all 70 tests. Lint and whitespace checks passed.
  • Independent review passed on the final patch. Private fixture checks preserve exact transport arguments, PID, signals, stderr, and exit status. Live SSH remains unverified.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T01:15:39.843123Z ac7b93a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread bin/tailmux Resolved
Comment thread bin/tailmux Resolved
@vriesd
vriesd merged commit 5b28274 into main Oct 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants