Repository navigation
feat(systems): each main gun fires its own kind of shot, and swapping has its own sound - #41
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Swapping guns mid-fight played the menu confirm chime, which sounds like a UI action rather than the ship changing weapons. A short mechanical cue (unlatch tick, rising whir, lock-in tick) tells the player the swap went through without masking gameplay sounds; it is quieter than the chime it replaces. It shows up in the soundboard with the other recipes. The refused-swap click is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After a swap the only cue was a one-second name flash, because Lance, Scatter and Seekers all fired the standard bolt. Now the fire itself says which gun is active and what it does: Lance shoots long white-hot needles, Scatter short round pellets, Seekers arrowhead darts. They stay in the player's cyan-white family with no ring or dark band, so they never read as enemy fire. The standard gun, the Wingman drone and the helper wing keep today's bolt. The look is part of each gun profile. All looks are same-sized frames of the one `player-bullet` texture, painted once when the pool is created, so a shot only switches frame when fired: no texture work mid-fight, no extra draw calls, and the 8x18 hitbox, damage and speed are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t a per-shot array The bolt's halo was cut off by its old 14x30 canvas; in the taller frame it showed a sliver above. It is clipped to the old box again. The first-shot test counts every paint of the strip again. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
vriesd
force-pushed
the
feat/gun-identity
branch
from
November 13, 2026 17:19
e65ec73 to
93a9211
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All four guns fired the same cyan bolt, so after swapping the only cue was a one-second name flash, and the swap played the generic menu confirm sound.
The four looks are frames of the one
player-bullettexture, still painted once before the sector starts, so shots stay in one batch and nothing is built mid-fight. The look lives in the gun profile next to its firing pattern.Proof: typecheck, lint, format, knip, unit tests and build pass;
shipSystems,firstShot,renderBudgetandautoFirepass on desktop and mobile (23 passed, 2 skipped by design), including a check that shots carry the new gun's look after a swap. I looked at screenshots of each gun firing on desktop and phone, and of Lance with enemy fire on screen. Nobody has listened to the new sound; it passes the recipe tests for level and clipping.Reviewed with sol-loop: 2 rounds with gpt-6.1-sol. Sol verdict: approved
Created with Claude Fable 5.2 in Claude Code (orchestration, review fixes); implementation by Claude Opus 5.5.
🤖 Generated with Claude Code