Repository navigation
fix(ui): the test case or Finding you selected stays selected when you come back to its tab - #155
Merged
Merged
Conversation
…u come back to its tab Selecting an older record, then opening another tab or starting a new draft from the Note, brought the tab back on the newest record: the record views unmount while another tab is open, and their selection lived inside them. The controller now remembers the selected record per view (useRecordSelection). The views start from it and report each selection; navigation that opens a specific record (Library, a route, a created record) sets it through focusRecord, which also keeps the route's focused record. Removes the unused statusLabel and the unused mergeRecordLists re-export. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe5a5a910f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…tab loads The view reports no selection while its records load, which cleared the record navigation had just focused, so the tab opened on the newest record. An empty report no longer clears the remembered selection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you selected an older test case or Finding (say the second one in the list), then went to another tab or started a new draft from the Note and cancelled it, the tab came back on the newest record instead of the one you picked.
The Test cases and Findings views unmount while another tab is open, and the selection lived inside them. The controller now remembers the selected record per view (
useRecordSelection): the views start from it and report each selection, and navigation that opens a specific record (Library, a route, a created record) sets it throughfocusRecord, which also keeps the route's focused record as before. The URL hash still only changes on navigation, not on every click.Also removes dead code: the unused
statusLabeland the unusedmergeRecordListsre-export.Proof: new
AppShell.recordSelection.test.tsxanduseRecordSelection.test.tsfail onmainand passes here;bun run verify:fastgreen (1579 tests); a temporary e2e spec in the built Tauri app selected the older of two test cases, switched Findings → Note → Test cases, then opened and cancelled Create test cases from the Note, and the older record stayed selected both times.Reviewed with sol-loop: 2 rounds with gpt-6.1-sol. Sol verdict: approved
Created with Claude Opus 5.5 in Claude Code (T3 Code).
🤖 Generated with Claude Code