Skip to content

refactor(flow): simplify guidance ownership and status routing - #211

Merged
vriesd merged 2 commits into
mainfrom
improve/flow-guidance-maintainability
Oct 28, 2026
Merged

vriesd merged 2 commits into
mainfrom
improve/flow-guidance-maintainability

Conversation

@vriesd

@vriesd vriesd commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Flow’s run guidance put recovery details ahead of normal work, while goal-alignment and delivery rules had multiple authored copies. This change records a phased improvement plan and a Flow-specific writing standard, embeds shared contracts into the existing guides, and makes read-only status follow explicit compact/error/detail/report branches.

Three development status scenarios reuse the existing eval runner. bun run eval:guidance combines the offline contracts, adversarial grader checks, native surface tests and recorded cassette replay; push preflight invokes it automatically. The contribution matrix now separates offline checks from separately authorized live model measurement. Release qualification thresholds and exact-artifact requirements are unchanged; no live model adherence improvement or new qualification is claimed.

Validation: clean push preflight passed (5,767 tests passed, 27 skipped, zero failures), 84 focused guidance checks passed, all 13 gated cassettes reproduced, and the packed native smoke passed 2 tests / 128 assertions with a local scripted provider. Authored skill text is about 18% smaller including shared fragments; the assembled manager context is effectively unchanged.

Phased plan · Flow writing standard

Reviewed with sol-loop: 3 rounds with GPT-6.1 Sol on high. Sol verdict: approved. Restored exact post-close archive recovery, rejected any tool after a status error, and preserved delivery and mutation disclosures on error handoff.

Merge decision: the non-required Codex review remained running beyond ten minutes on the final head. Proceeding under full-send’s stalled-review rule with current-diff Sol approval, Seer success, all eight checks green, and no unresolved findings or human change requests.

Created with GPT-6.1 Sol in T3 Code.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-28T19:49:57.713819Z 04a43fc Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread src/prompt-surfaces.ts Resolved

vriesd commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Note

🤖 GPT-6.1 Sol responding on behalf of vriesd

@codex review

Please review current head 04a43fc, including the status-error delivery fix and archive-collision regression.

@vriesd
vriesd merged commit c01b6fb into main Oct 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants