Repository navigation
refactor(flow): simplify guidance ownership and status routing - #211
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flow’s run guidance put recovery details ahead of normal work, while goal-alignment and delivery rules had multiple authored copies. This change records a phased improvement plan and a Flow-specific writing standard, embeds shared contracts into the existing guides, and makes read-only status follow explicit compact/error/detail/report branches.
Three development status scenarios reuse the existing eval runner.
bun run eval:guidancecombines the offline contracts, adversarial grader checks, native surface tests and recorded cassette replay; push preflight invokes it automatically. The contribution matrix now separates offline checks from separately authorized live model measurement. Release qualification thresholds and exact-artifact requirements are unchanged; no live model adherence improvement or new qualification is claimed.Validation: clean push preflight passed (5,767 tests passed, 27 skipped, zero failures), 84 focused guidance checks passed, all 13 gated cassettes reproduced, and the packed native smoke passed 2 tests / 128 assertions with a local scripted provider. Authored skill text is about 18% smaller including shared fragments; the assembled manager context is effectively unchanged.
Phased plan · Flow writing standard
Reviewed with sol-loop: 3 rounds with GPT-6.1 Sol on high. Sol verdict: approved. Restored exact post-close archive recovery, rejected any tool after a status error, and preserved delivery and mutation disclosures on error handoff.
Merge decision: the non-required Codex review remained running beyond ten minutes on the final head. Proceeding under full-send’s stalled-review rule with current-diff Sol approval, Seer success, all eight checks green, and no unresolved findings or human change requests.
Created with GPT-6.1 Sol in T3 Code.