Skip to content

fix(ci): separate main readiness from qualified publication - #206

Merged
vriesd merged 1 commit into
mainfrom
fix/main-release-readiness
Oct 27, 2026
Merged

vriesd merged 1 commit into
mainfrom
fix/main-release-readiness

Conversation

@vriesd

@vriesd vriesd commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

After #205 changed plugin implementation bytes, main’s nonpublishing Release workflow tried restoring the old qualified 10.0.0 artifact and failed its exact-content check. Main should build the development candidate and report readiness without claiming it is qualified.

Use the existing release decision to reserve v2 restoration in the verification job for publishing invocations. Main keeps metadata/canary dry-run reporting. The publishing job, strict artifact validators, historical evidence, and 9.x behavior are unchanged.

Proof: the new main regression fails against the original workflow and passes with this correction; tag and publishing controls still restore exact artifacts and reject mismatches. All 45 focused tests, typecheck, actionlint, and canonical push preflight pass (5,746 tests, 27 skipped, zero failures). Actual workflow shell preparation/readiness reports the changed candidate NOT VERIFIED without failure.

Reviewed with sol-loop: 1 round with gpt-6.1-sol on high. Sol verdict: approved.

Created with gpt-6.1-sol in T3 Code through the Codex harness.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T18:53:01.754558Z 309e897 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vriesd
vriesd merged commit 355b0ee into main Oct 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants