Skip to content

fix(evals): wait for native OAuth routing before dispatch - #202

Merged
vriesd merged 4 commits into
mainfrom
fix/native-oauth-readiness
Oct 25, 2026
Merged

vriesd merged 4 commits into
mainfrom
fix/native-oauth-readiness

Conversation

@vriesd

@vriesd vriesd commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Why

Native-account evaluation hosts could return before OpenCode finished deriving OAuth routing. A resolved credential could then reach the standard API route. This waits for settled credentials and routing before dispatch.

What changed

  • Add a private readiness RPC and one host adapter, checked after credential import and before model accounting.
  • Check the final legacy OpenAI Request target and account header while preserving source ownership and generic OAuth behavior.
  • Add readiness, cancellation, privacy, variant, catalog diagnostic, and charging regressions. Failed canary launches remain charged once.

Scope

  • Evaluation and canary authentication setup for existing native accounts.
  • The published plugin, package version, and qualification thresholds retain their current behavior.

Tradeoffs

Supported native metadata provides an observation rather than an atomic lock. A state change after accounting can still consume a dispatch before the final guard refuses transport.

Blast Radius

Native-account evaluation hosts gain a readiness gate. Environment credentials and explicit credential handoffs retain their existing call order.

Verification

  • Full contribution preflight passed, including 5,234 tests with zero failures.
  • Five original regressions changed from failing to passing. The focused suite passed 137 tests, with two native opt-in skips.
  • A private OpenCode 2.1.4 fixture exercised the actual readiness RPC and adapter. Held-loader and settled states passed with zero external provider fetches.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T15:04:29.964080Z 7b4d38f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread evals/native-auth/client-plugin.ts Resolved
@vriesd
vriesd merged commit ae7b236 into main Oct 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants