Skip to content

Refresh cached browser icons when artwork changes - #28

Merged
vriesd merged 1 commit into
mainfrom
fix-browser-tab-icon
Nov 15, 2026
Merged

vriesd merged 1 commit into
mainfrom
fix-browser-tab-icon

Conversation

@vriesd

@vriesd vriesd commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Returning players can retain an old browser tab icon even though the current export contains the Farlanding artwork. Web exports now version favicon and Apple touch icon URLs with their image content hashes, so changed artwork gets a fresh cache key. The release manifest is generated afterward and deployment keeps the verified files intact.

A browser regression verifies the URL version and compares the tab icon’s pixels with the branded launcher image before and after Godot starts. A fresh production browser already showed the correct artwork; stale favicon caching is the likely cause of the reported old Godot icon.

Proof: regression failed on the old unversioned export; rebuilt Web and WebDiagnostics exports passed; launcher, real mission launch and favicon checks passed 3/3 in Chromium and 3/3 in WebKit. All 22 Python tooling tests, project integrity, shell syntax and diff checks passed.

Reviewed with sol-loop: 1 round with GPT-6.1 Sol on medium. Sol verdict: approved, no findings.

Created with GPT-6.1 Sol in T3 Code through the Codex harness.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T15:38:37.574958Z 0d61003 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vriesd
vriesd merged commit 3bba4c7 into main Nov 15, 2026
4 checks passed
@vriesd
vriesd deleted the fix-browser-tab-icon branch November 15, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants