Skip to content

Keep Godot warnings clean and title menus readable - #26

Merged
vriesd merged 1 commit into
mainfrom
fix-editor-warning-gate
Nov 15, 2026
Merged

vriesd merged 1 commit into
mainfrom
fix-editor-warning-gate

Conversation

@vriesd

@vriesd vriesd commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

The editor still showed genuine GDScript warnings even though runtime-only loading passed. Every previously enabled Warn category is now Error, and the script checker rejects globally disabled warnings or categories left at Warn. Fresh-process boundary tests exercise that policy. Mechanical naming/static-call fixes remove the diagnostics; explicit integer truncation preserves existing calculations. One documented unused_signal annotation covers a signal emitted by Carrier.

Audio explicitly preloads its typed playback dependency so the editor need not resolve a newly indexed global class before the autoload compiles. The title also fits supported window/UI sizes without a scrollbar: primary actions stay stacked with Load game directly below Single missions, while secondary actions share a compact grid. Heading/spacing adapt, and unusually short windows retain scrolling access.

Proof: full stricter native checks passed 795 gameplay tests, 420 real-mixer audio tests, all 11 mission smoke tests and 1,103 resource loads; all 22 tooling tests and 28 Chromium gameplay/menu/UI checks passed. Regression evidence covers the former title overflow and weakened warning-policy configurations. Live Godot MCP checks confirmed the active script error is gone and the title fits. Numeric comparison preserved signed truncation and audio measurements. The rebuilt full Web mixer passed 420 tests with zero failures; WebKit launcher/load flows passed both checks.

No asset, score, shader, save-format or rendering-quality change. Incidental stale-editor resource resaves were caught by the mixer tests, restored before pushing, and verified absent after reloading the editor from disk.

Reviewed with sol-loop: 2 rounds with GPT-6.1 Sol on medium. Sol verdict: approved.

Created with GPT-6.1 Sol in T3 Code (Codex).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T13:28:31.495039Z 51dd7ad PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vriesd
vriesd merged commit 0bcf2da into main Nov 15, 2026
4 checks passed
@vriesd
vriesd deleted the fix-editor-warning-gate branch November 15, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants