Repository navigation
Keep Godot warnings clean and title menus readable - #26
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The editor still showed genuine GDScript warnings even though runtime-only loading passed. Every previously enabled Warn category is now Error, and the script checker rejects globally disabled warnings or categories left at Warn. Fresh-process boundary tests exercise that policy. Mechanical naming/static-call fixes remove the diagnostics; explicit integer truncation preserves existing calculations. One documented
unused_signalannotation covers a signal emitted by Carrier.Audio explicitly preloads its typed playback dependency so the editor need not resolve a newly indexed global class before the autoload compiles. The title also fits supported window/UI sizes without a scrollbar: primary actions stay stacked with Load game directly below Single missions, while secondary actions share a compact grid. Heading/spacing adapt, and unusually short windows retain scrolling access.
Proof: full stricter native checks passed 795 gameplay tests, 420 real-mixer audio tests, all 11 mission smoke tests and 1,103 resource loads; all 22 tooling tests and 28 Chromium gameplay/menu/UI checks passed. Regression evidence covers the former title overflow and weakened warning-policy configurations. Live Godot MCP checks confirmed the active script error is gone and the title fits. Numeric comparison preserved signed truncation and audio measurements. The rebuilt full Web mixer passed 420 tests with zero failures; WebKit launcher/load flows passed both checks.
No asset, score, shader, save-format or rendering-quality change. Incidental stale-editor resource resaves were caught by the mixer tests, restored before pushing, and verified absent after reloading the editor from disk.
Reviewed with sol-loop: 2 rounds with GPT-6.1 Sol on medium. Sol verdict: approved.
Created with GPT-6.1 Sol in T3 Code (Codex).