Skip to content

Improve diagnostics, save flow, and base management - #25

Merged
vriesd merged 1 commit into
mainfrom
improve-project-maintainability
Nov 15, 2026
Merged

vriesd merged 1 commit into
mainfrom
improve-project-maintainability

Conversation

@vriesd

@vriesd vriesd commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

The warning gate previously passed with an unfreed fixture and deprecated test calls. Map access, save preflight and large orchestration methods also made changes harder to verify. This tightens diagnostics and asset/dependency checks, uses the existing typed map contract, separates one-shot playback, and gives world restoration explicit ordered phases. Malformed saves are refused before replacing the current landing; legacy save formats remain supported.

The requested gameplay and menu improvements are included:

  • Load game sits directly below Single missions; Back/Escape and modal focus return safely. Continue resolves same-second save ties by actual write order.
  • Owned placeable buildings can be sold with a refund preview and confirmation. Finished buildings return 50%, unfinished sites 100%, with queued units refunded normally. Lander/story machines stay protected; sales release navigation/power/vents and do not count as combat losses.
  • Discoveries are found through exploration, with no advance question marks or survey-location beacons. Scanning keeps its feedback/rewards; completed player surveys become map records, including across loads.
  • The browser launcher matches the game palette, puts clearly explained graphics overrides under Launch options, and uses the new favicon. README points to https://farlanding.app.

The phased plan and research links are in docs/MAINTAINABILITY_PLAN.md; ADR 0023 records the exploration policy. Rendering settings and quality are preserved; no unmeasured performance claim is made.

Proof: complete native checks passed (793 gameplay tests, 420 real-mixer audio tests, all 11 mission smoke tests, zero diagnostics), plus 14 current menu/exploration regressions, 18 Python tooling tests and all 29 Chromium graphics/UI/gameplay/persistence checks. Failing-before regressions cover prop overlap, malformed saves, same-second slot ordering and discovery visibility. The full Web mixer also passed 420 tests with zero failures; 10 additional browser mission boots passed.

Reviewed with sol-loop: 2 rounds with GPT-6.1 Sol on medium. Sol verdict: approved.

Created with GPT-6.1 Sol in T3 Code (Codex), with a GPT-6 Astra audit. Claude Opus 5.5 through Claude created only the favicon, as explicitly requested.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T11:55:38.117326Z cd7529a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vriesd
vriesd merged commit 86ae4ca into main Nov 15, 2026
4 checks passed
@vriesd
vriesd deleted the improve-project-maintainability branch November 15, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants