Repository navigation
Improve diagnostics, save flow, and base management - #25
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning gate previously passed with an unfreed fixture and deprecated test calls. Map access, save preflight and large orchestration methods also made changes harder to verify. This tightens diagnostics and asset/dependency checks, uses the existing typed map contract, separates one-shot playback, and gives world restoration explicit ordered phases. Malformed saves are refused before replacing the current landing; legacy save formats remain supported.
The requested gameplay and menu improvements are included:
The phased plan and research links are in
docs/MAINTAINABILITY_PLAN.md; ADR 0023 records the exploration policy. Rendering settings and quality are preserved; no unmeasured performance claim is made.Proof: complete native checks passed (793 gameplay tests, 420 real-mixer audio tests, all 11 mission smoke tests, zero diagnostics), plus 14 current menu/exploration regressions, 18 Python tooling tests and all 29 Chromium graphics/UI/gameplay/persistence checks. Failing-before regressions cover prop overlap, malformed saves, same-second slot ordering and discovery visibility. The full Web mixer also passed 420 tests with zero failures; 10 additional browser mission boots passed.
Reviewed with sol-loop: 2 rounds with GPT-6.1 Sol on medium. Sol verdict: approved.
Created with GPT-6.1 Sol in T3 Code (Codex), with a GPT-6 Astra audit. Claude Opus 5.5 through Claude created only the favicon, as explicitly requested.