Repository navigation
Deploy the tested Web release to Vercel through CI - #20
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 057b6d2851
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Farlanding's Web build is tested in CI but has no production deployment. Add a main-only Vercel deployment after the native and browser jobs, following Space Explorer's CI-controlled production setup. Use Node 26.x and Vercel CLI 65.16.0; the companion Space Explorer upgrade is ddv1982/space-explorer#47.
The existing Vercel team is Hobby, and the exported game exceeds its 100 MB CLI source-upload limit. Upload a small build referring to the current run's artifact ID and digest. Resolve GitHub's one-minute redirect inside the build with the deployment job's temporary, repository-scoped read-only token as a build-only secret. Never store the token in source/public assets or forward it to redirected storage. Verify the archive digest and complete clean-release manifest before publishing. Godot is not rebuilt on Vercel.
Serve the isolation headers required by threaded audio and the WebAssembly MIME type. Exercise a protected staged deployment with real browser input before promotion, then check the stable production domain without authentication. Keep bypass credentials out of traces, serialize production runs, and allow artifact uploads to be rerun.
Native CI also exposed an intermittent final-mix measurement failure: the global RNG seed did not control the audio directors' own RNGs or inherited bed playback positions. Reset those fixture inputs for each scene. Production audio and the 3.5/4.5 LU comparison limits are unchanged; the full native audio suite passed 416 tests / 6,374 assertions with no engine errors or warnings after the reset.
Validation: workflow actionlint, JavaScript syntax, six deployment-tool tests and five existing Web-tool tests passed. A real Hobby deployment downloaded and verified the green main artifact and reached a playable Kessel landing with no browser errors. That smoke check caught and fixed the bypass cookie needed by audio worklets on protected URLs. The revised build-time redirect path retrieved and verified the real nine-file release locally, with regressions proving that preparation stores no expiring URL/token and redirected requests carry no GitHub authorization. The project and CI credentials/production URL are configured; CI will validate its job token and perform the first public promotion after merge.
Created with GPT-6.1 Sol in T3 Code through the Codex harness.