Skip to content

ci: stop running check on release tags - #210

Merged
vriesd merged 1 commit into
mainfrom
ci/check-skip-tags
Oct 28, 2026
Merged

vriesd merged 1 commit into
mainfrom
ci/check-skip-tags

Conversation

@vriesd

@vriesd vriesd commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Drops the v* tag trigger from check.yml. A release tag points at a main commit whose push already ran check, and nothing in release.yml waits on it, so the tag run only rebuilt and retested the same SHA (v1.0.10: run on ea9b998 at 03:58 for main, again at 04:27 for the tag). Release builds from tags are unchanged; release.yml still triggers on v*.

Proof: actionlint and verify-workflow-pinning.py (plus --self-test) pass; parsed triggers are now push: main and pull_request.

🤖 Generated with Claude Code

A v* tag must point at a main commit whose push already ran check, and the tag release workflow does not depend on check, so the tag run only rebuilt and retested the same SHA.
@vriesd

vriesd commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T04:45:08.929305Z c75ae16 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: c75ae16b7f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@vriesd
vriesd merged commit a264076 into main Oct 28, 2026
14 checks passed
vriesd added a commit that referenced this pull request Oct 29, 2026
Release #210 so the next tag push shows check no longer runs on release tags. Align workspace, lockfile, changelog and AppStream metadata. The application is unchanged from v1.0.10.

Co-authored-by: vriesd <douwe.de.vries@crv4all.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants