Skip to content

fix: drop the Wayland titlebar workaround now that Tauri 2.12 fixes it - #208

Merged
vriesd merged 1 commit into
mainfrom
fix/drop-wayland-titlebar-workaround
Oct 28, 2026
Merged

vriesd merged 1 commit into
mainfrom
fix/drop-wayland-titlebar-workaround

Conversation

@vriesd

@vriesd vriesd commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

On Wayland, reopening Echo from the tray used to leave the titlebar buttons dead (tauri-apps/tauri#11856). show_main_window worked around it by toggling resizability off and on, with a note to remove that once Tauri 2.12/tao 0.36 shipped the real fix. Tauri 2.12 (#207) brings tao 0.37.2, which includes tauri-apps/tao#1218: it restores GTK's own client-side decorations and fixes the bug. This PR removes the workaround.

Proof: I tested on this GNOME 46 Wayland session at 1.5× scale. Each app ran on an empty workspace with an isolated D-Bus session and PID namespace, and clicks were injected through Mutter RemoteDesktop at calibrated coordinates.

  • Tauri 2.11 (tao 0.35.3), workaround removed: the buttons work on a fresh window. After close-to-tray and reopen, two maximize clicks and one close click do nothing, which reproduces the bug.
  • This branch, Tauri 2.12 (tao 0.37.2): after close-to-tray and reopen, maximize, restore, and close all respond.
  • fmt and clippy are clean, and xvfb-run cargo test --workspace passes (621 tests).

Created with Claude Opus 5.5 in Claude Code. Reviewed with sol-loop: 1 round with gpt-6.1-sol. Sol verdict: approved

show_main_window toggled resizability after restoring a tray-hidden
window on Wayland because titlebar buttons stopped responding
(tauri-apps/tauri#11856). tao 0.36 (tauri-apps/tao#1218) restored GTK's
own client-side decorations, and Tauri 2.12 ships tao 0.37.2, so the
workaround is no longer needed.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T00:35:09.454365Z 8970494 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vriesd
vriesd merged commit 633d102 into main Oct 28, 2026
14 checks passed
vriesd added a commit that referenced this pull request Oct 28, 2026
Release the Tauri 2.12 upgrade (#207), the Wayland titlebar fix it enables (#208), and the shared CI build setup (#206). Align workspace, lockfile, changelog and AppStream metadata.

Co-authored-by: vriesd <douwe.de.vries@crv4all.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants