Repository navigation
fix: drop the Wayland titlebar workaround now that Tauri 2.12 fixes it - #208
Merged
Merged
Conversation
show_main_window toggled resizability after restoring a tray-hidden window on Wayland because titlebar buttons stopped responding (tauri-apps/tauri#11856). tao 0.36 (tauri-apps/tao#1218) restored GTK's own client-side decorations, and Tauri 2.12 ships tao 0.37.2, so the workaround is no longer needed.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Wayland, reopening Echo from the tray used to leave the titlebar buttons dead (tauri-apps/tauri#11856).
show_main_windowworked around it by toggling resizability off and on, with a note to remove that once Tauri 2.12/tao 0.36 shipped the real fix. Tauri 2.12 (#207) brings tao 0.37.2, which includes tauri-apps/tao#1218: it restores GTK's own client-side decorations and fixes the bug. This PR removes the workaround.Proof: I tested on this GNOME 46 Wayland session at 1.5× scale. Each app ran on an empty workspace with an isolated D-Bus session and PID namespace, and clicks were injected through Mutter RemoteDesktop at calibrated coordinates.
xvfb-run cargo test --workspacepasses (621 tests).Created with Claude Opus 5.5 in Claude Code. Reviewed with sol-loop: 1 round with gpt-6.1-sol. Sol verdict: approved